Comments (2)
The issue is that the reply code is not checked, success is reported on any reply
a start would be to actually check the code:
index 7592db0..2f09a79 100644
--- a/gping.py
+++ b/gping.py
@@ -204,7 +204,12 @@ class GPing:
self.pings[packet_id]['delay'] = time_received - time_sent
# i'd call that a success
- self.pings[packet_id]['success'] = True
+ if code == 0:
+ self.pings[packet_id]['success'] = True
+ else
+ self.pings[packet_id]['success'] = False
+
+ self.pings[packet_id]['code'] = code
# call our callback if we've got one
self.pings[packet_id]['callback'](self.pings[packet_id])
from python-ping.
I met this problem too.
The reason that this happened is "os.getpid()" returns the same number while multithreading.
os.getpid() returns different number while multiprocessing.
the way to solve this is replace "my_ID = os.getpid() & 0xFFFF" by "my_ID = threading.current_thread().ident & 0xFFFF"(py3) in do_one() function.
I'll fix this in ping3.py and ask for a merge.
before the pull request works, see my branch @ https://github.com/kyan001/python-ping
from python-ping.
Related Issues (6)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from python-ping.