Improvement - Map reference about react-map-gl-geocoder

[marek-sed]

Yeah was thinking about a bit it seems like a new component now. It would require too many if, else blocks and make it hard erto maintain.

Will try to open-source it after I have some more time.

btw thank you for making this library its 💯

[SamSamskies]

Hi @marek-sed, without the map, nothing will work. This component performs imperative actions using the Mapbox map which is obtained using the imperative getMap function from the react-map-gl Map https://github.com/SamSamskies/react-map-gl-geocoder/blob/master/src/index.js#L114. That's why the render function returns null. https://github.com/SamSamskies/react-map-gl-geocoder/blob/master/src/index.js#L230

[marek-sed]

which imperative actions?

copied your geocoder to our project, geocoding works ;)
https://gist.github.com/marek-sed/7a2f2a086647ad10db282014d6804d57#file-geocoder-js-L85

I am not using map related props. Just need a typeahed with calling service.
It is really nice for placing geocoder outside of map and plays nicely with react-map-gl which extracts the viewport. So I can set mapCenter to global state, and update the viewport.

in my understanding it is sort of the point of using react-map-gl so you can couple pieces in composable manner.

and sry would love to provide codesandbox example but we have crazy tight schedule on project

[SamSamskies]

The imperative actions I was talking about are the Mapbox map imperative actions such as addControl https://github.com/SamSamskies/react-map-gl-geocoder/blob/master/src/index.js#L93.

When I first started this project, I didn't know you could add the @mapbox/mapbox-gl-geocoder object by appending it to an outside HTML node. I didn't discover this until later when someone raised an issue that they'd like to place the geocoder outside of the map.

At this point, I think most people use this component without the containerRef and I believe the changes that you suggest would require it.

Let me know if you decide to open source your more composable solution and I'll add a link in the README.