Comments (6)
Should be fixed now. The zooming can be improved to zoom in on the bounding box of the area that is searched for. I'll add that later.
Note that there's a new required prop called onViewportChange.
Let me know if you have any problems.
from react-map-gl-geocoder.
Thanks for reporting these bugs. I'm probably not going to have time to fix this tonight, so feel free to have a go at it.
from react-map-gl-geocoder.
You could probably listen for the zoomend event and update the lat, lng, and zoom of the viewport then.
from react-map-gl-geocoder.
Spent a little more time looking at this, and the implementation of the onViewportChange in NavigationControl was significantly more involved than I thought it was going to be. Listening for zoomend sounds promising, but not sure on implementation details for that.
from react-map-gl-geocoder.
The results and result event from mapbox-gl-geocoder might also be worth looking into.
https://github.com/mapbox/mapbox-gl-geocoder/blob/master/API.md
Here's the docs for the zoomend mapbox-gl map event.
https://www.mapbox.com/mapbox-gl-js/api/#map.event:zoomend
I think we may need to get rid of the the animation transition to get this to work. I'm not sure how we'd animate deck.gl layers along with the base map.
If I get a second wind later tonight, I'll have a crack at it.
from react-map-gl-geocoder.
Cheers, thanks for this! Works great with deck.gl layers now, including during animation.
from react-map-gl-geocoder.
Related Issues (20)
- GeoCoder Marker's Styling Not Working HOT 2
- Search Results Not closing, and marker not dropping HOT 9
- Geocoder doesn't appear in Next.js app HOT 1
- Console error passing object to marker prop
- Suggestions are displayed after setting a default input HOT 3
- External geocoder HOT 1
- React 17? HOT 1
- how to active draggable after search HOT 1
- mapbox-gl neccessary dependency? HOT 1
- How to get the current value? HOT 3
- Typescript import issue HOT 1
- Supporting stand-alone Geocoder without map ? HOT 1
- react-map-gl 7 support HOT 7
- Multiple input options in react app HOT 1
- export 'FlyToInterpolator' (imported as 'r') was not found in 'react-map-gl' HOT 2
- Request to upgrade transitive dependency `http-cache-semantics` in `react-map-gl-geocoder` HOT 1
- Menu stays open HOT 2
- Upon passing Marker="true" into geocoder, no point appears HOT 4
- TypeError: Cannot read property 'remove' of undefined __ Cannot read property 'addControl' of null - HOT 6
- Can Not Use react.map.gl.gecoder with Typescript HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-map-gl-geocoder.