Shutdown of Dojo and bitcoind about samourai-dojo

[Technifocal]

Apparently Docker supports wait:

https://docs.docker.com/engine/reference/commandline/wait/

Replace the entire above loop with just:

timeout 3m docker wait bitcoind

It'll wait till the container closes, or 3 minutes. Whichever is sooner.

[Technifocal]

Here is an example (untested) loop demonstration what @LaurentMT mentioned at the end:

# Stop
stop() {
  if [ "$BITCOIND_INSTALL" == "on" ]; then
    if [ "$BITCOIND_EPHEMERAL_HS" = "on" ]; then
      docker exec -it tor rm -rf /var/lib/tor/hsv2bitcoind
    fi

    docker exec -it bitcoind bitcoin-cli \
      -rpcconnect=bitcoind \
      --rpcport=28256 \
      --rpcuser="$BITCOIND_RPC_USER" \
      --rpcpassword="$BITCOIND_RPC_PASSWORD" \
      stop

    echo "Preparing shutdown of dojo. Please wait."

    terminationCount=180;

    while [ "${?}" -eq "0" ] || [ "${terminationCount}" -le "0" ]; do
	    terminationCount="$((terminationCount - 1))";
	    sleep 1s;
    	docker exec -it bitcoind bitcoin-cli \
	      -rpcconnect=bitcoind \
	      --rpcport=28256 \
	      --rpcuser="$BITCOIND_RPC_USER" \
	      --rpcpassword="$BITCOIND_RPC_PASSWORD" \
	      uptime;
    done;
  fi

  yamlFiles=$(select_yaml_files)
  eval "docker-compose $yamlFiles down"
}

Potentially replace:

docker exec -it bitcoind bitcoin-cli \
	      -rpcconnect=bitcoind \
	      --rpcport=28256 \
	      --rpcuser="$BITCOIND_RPC_USER" \
	      --rpcpassword="$BITCOIND_RPC_PASSWORD" \
	      uptime;

with:

docker exec -it bitcoind true

Which will always return true while the bitcoin-cli container exists, or replace it with something that actually checks the container status.