Coder Social home page Coder Social logo

Comments (4)

kenshin-samourai avatar kenshin-samourai commented on July 17, 2024

a couple of remarks

  • localhost isn't going to work when containers run in a vm (mac os, windows)
  • make it optional? (default = no port exposed)

from samourai-dojo.

kenshin-samourai avatar kenshin-samourai commented on July 17, 2024

Implemented in PR #8 as an option

Setup in /my-dojo/conf/docker-bitcoind.conf

  • BITCOIND_RPC_EXTERNAL allows to expose/hide the rpc api outside of docker (default = hidden)
  • BITCOIND_RPC_EXTERNAL_IP allows to set the correct ip address (default = 127.0.0.1)

Exposes the rpc api and zmq notifications (blockhash and rawtx)

Doesn't require a new install or an upgrade, just a restart of dojo

from samourai-dojo.

LaurentMT avatar LaurentMT commented on July 17, 2024

It might be a good idea to expose all ZMQ ports when this option is activated.
Some apps rely on notifications which aren't required by Dojo.
(e.g.: lnd requires zmqpubrawblock source: https://gist.github.com/05nelsonm/ef55dcc1fb3aa588c8135cd107ee5d8c)

from samourai-dojo.

kenshin-samourai avatar kenshin-samourai commented on July 17, 2024

support of additional ports and number of rpc threads implemented in PR #12

from samourai-dojo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.