Issue with foreach over ienumerable about saltarellecompiler

[erik-kallen]

try/finally does not swallow exceptions. Also, the try/finally adds little overhead according to the tests. Removing the dispose() call altogether does improve performance on Chrome but not on the iPad, but if this is removed we have other problems such as finally blocks in iterator blocks not being executed. (btw, if you foreach over an array it should be optimized to a for loop).

[dested]

Sorry I jumped the gun, obviously I was dealing with a separate issue with an exception.

Thats interesting about the ipad, must be in the way it inlines the method differently than chrome. My issue was foreaching over an ienumerable that was an array. I suppose an answer is to be careful during performance critical situations to iterate over an array rather than an ienumerable. Thanks for the insight.

[erik-kallen]

The overhead is also likely to be less when the loop actually does something (overhead = O(1), loop work = O(n))

[dested]

Would you consider adding the optimization for arrays to List<T>'s as well? It seems safe enough