Comments (4)
Unfortunately this is working as expected, though the README dances around the issue a little 😞
Currently localClassNameBindings
only works for toggling classes based on a boolean value. Mapping string values basically requires one more layer of indirection than you can package up in a single computed, since the name of the property you're binding to in turn depends on a dynamic property value.
It's possible we may be able to come up with a way around this by manually Ember.bind
ing things on init, but we should be careful of the perf costs of setting up these extra bindings. Will need to noodle on it some.
from ember-css-modules.
Actually, it looks like the README lies and says strings will be coerced and treated as booleans, which clearly isn't the case. I'll update that for the time being to be clearer(/actually accurate).
from ember-css-modules.
Cant we just do something like this:
init() {
this._super(...arguments);
const names = get(this, 'localClassNameBindings');
get(this, 'classNameBindings').pushObject('__local_class_names');
set(this, '__local_class_names', Ember.computed(...names, function() {
return names
.map(n => get(this, n)) // get property value
.map(c => c.split(' ')) // get array of array of classes
.reduce((a, b) => [...a, ...b]) // flatten to array of classes
.map(v => styles[v]) // get local class name
.filter(s => s) // remove non-existring
.join(' ');
}));
},
from ember-css-modules.
Fixed by #81
from ember-css-modules.
Related Issues (20)
- Is there a codemod to colocate CSS modules with their components? HOT 2
- Turn off `Component.reopen()` call
- Deprecation use of Reopening the Ember.Component super class HOT 2
- Why we don't have tests that covers `Ember Engines`
- Incompatible with `postcss-nested` 5+ HOT 2
- Not compatible with Ember 4 HOT 3
- Question: How to use it on Ember Engines HOT 1
- Doesn't work with `ember-cli-sass`
- css file hash doesn't use correct path when generating-scoped-name in embroider app build, when consuming an addon using ecm HOT 1
- Provide exclude glob option HOT 1
- Tree passed to preprocessors for app and addon is not scoped with moduleName
- Replace local-class with class at build time instead of runtime HOT 2
- Question: How to use it with v2 addon? HOT 1
- Documenting migration from global app.css to css-modules
- pod route template: using `local-class` throws error HOT 1
- how to disable shipping JS modules?
- Usage in addons + Embroider build
- Heroku build got stuck in 1.6.2
- vendor files imported via postcss-import not being recompiled on change.
- Support for ember-template-imports? HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-css-modules.