Comments (2)
In general, component inheritance tends to be difficult to work with because HTML/Handlebars templates don't have any notion of inheritance. As you rightly point out, CSS modules compound this problem by making you also repeat your class usage everywhere.
One option would be to do something like this:
// app/features/components/base-card/component.js
import styles from './styles';
export default Component.extend({
baseStyles: styles
// ...
});
You'd then be able to reference the base class's styles like class={{baseStyles.name}}
in the template for your derived component templates like app-card
.
However, if possible I would take a step back and look at whether you might be able achieve the reuse you're after with composition rather than inheritance. In general I've found composing derived components from more general base ones to be a lot less painful than trying to manage such reuse via subclassing.
What if instead of extending base-card
, app-card
's template just invoked {{base-card}}
? You could imagine using something like ember-block-slots or ember-named-yields to make different sections of your base card overridable on a case by case basis, without having to duplicate the markup of the entire card structure.
Looking at your app-card
example, it looks like you're wanting to adjust the styles for one fairly deeply-nested class. Without knowing the full details, the icon might be a good candidate to be a slot with some default content in base-card
that could be overridden in app-card
's usage of it.
ember-power-select is a good example of a component that's built up this way (though with only a single yield
rather than using multiple slots).
from ember-css-modules.
@duro I'm going to go ahead and close this since I don't think there are any actionable changes here for the addon, but if you have further thoughts or questions please feel free to reopen or start a new issue.
from ember-css-modules.
Related Issues (20)
- Is there a codemod to colocate CSS modules with their components? HOT 2
- Turn off `Component.reopen()` call
- Deprecation use of Reopening the Ember.Component super class HOT 2
- Why we don't have tests that covers `Ember Engines`
- Incompatible with `postcss-nested` 5+ HOT 2
- Not compatible with Ember 4 HOT 3
- Question: How to use it on Ember Engines HOT 1
- Doesn't work with `ember-cli-sass`
- css file hash doesn't use correct path when generating-scoped-name in embroider app build, when consuming an addon using ecm HOT 1
- Provide exclude glob option HOT 1
- Tree passed to preprocessors for app and addon is not scoped with moduleName
- Replace local-class with class at build time instead of runtime HOT 2
- Question: How to use it with v2 addon? HOT 1
- Documenting migration from global app.css to css-modules
- pod route template: using `local-class` throws error HOT 1
- how to disable shipping JS modules?
- Usage in addons + Embroider build
- Heroku build got stuck in 1.6.2
- vendor files imported via postcss-import not being recompiled on change.
- Support for ember-template-imports? HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-css-modules.