Comments (4)
I was thinking about this actually. With a handlebars AST tranformation all interpolations could be done in compile time.
I'd suggest some syntax like class="global-class {{someLocalPropertyLikeActiveOrDisabledOrSomething}} {{:moduleCSSClass}}"
I think that it removes the cognitive overhead of having a different attribute that text-editors don't know to autocomplete, and doing all the work in compilation time would save the component to have to hold javascript styles on it (even if it's a object that will never change)
from ember-css-modules.
I actually started down the path of doing template interpolation at compile time (I still have a proof-of-concept branch somewhere), but unfortunately it doesn't mesh well with class composition.
.foo {
composes: bar;
}
Given the above, the CSS Modules compilation process doesn't change the definition of .foo
to incorporate .bar
's styles like a Sass @include
or add the .foo
selector to .bar
's definition like @extend
βΒ in fact, the class definitions aren't changed at all.
Instead, the value for foo
in the exported styles hash will contain references to the namespaced version of both foo
and bar
, so any element withclass={{styles.foo}}
will end having both classes assigned.
This means that to statically interpolate the namespaced classes during template compilation, the stylesheets need to already have been processed, and we need access to that output from the AST transform. Ember CLI's build pipeline doesn't guarantee the former, and it actively prevents the latter, so I settled for pulling the class names at runtime.
Given that, I'd be hesitant to introduce a microsyntax like {{:moduleCSSClass}}
, since it would just be notational shorthand for {{styles.moduleCSSClass}}
rather than meaning something distinct at build time.
from ember-css-modules.
Given that, I'd be hesitant to introduce a microsyntax like {{:moduleCSSClass}}
No question, this microsyntax was only an idea to mark nodes for a possible precompilation by a handlebars AST. I doesn't makes sense just to save a few keystrokes if the interpolation happens in runtime.
from ember-css-modules.
This is now released as local-class="foo"
in 0.4.0.
from ember-css-modules.
Related Issues (20)
- Generate modules on-the-fly?
- Is there a codemod to colocate CSS modules with their components? HOT 2
- Turn off `Component.reopen()` call
- Deprecation use of Reopening the Ember.Component super class HOT 2
- Why we don't have tests that covers `Ember Engines`
- Incompatible with `postcss-nested` 5+ HOT 2
- Not compatible with Ember 4 HOT 3
- Question: How to use it on Ember Engines HOT 1
- Doesn't work with `ember-cli-sass`
- css file hash doesn't use correct path when generating-scoped-name in embroider app build, when consuming an addon using ecm HOT 1
- Provide exclude glob option HOT 1
- Tree passed to preprocessors for app and addon is not scoped with moduleName
- Replace local-class with class at build time instead of runtime HOT 2
- Question: How to use it with v2 addon? HOT 1
- Documenting migration from global app.css to css-modules
- pod route template: using `local-class` throws error HOT 1
- how to disable shipping JS modules?
- Usage in addons + Embroider build
- Heroku build got stuck in 1.6.2
- vendor files imported via postcss-import not being recompiled on change.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-css-modules.