facter3 results in 502 on checkin about sal

[grahamgilbert]

So this is due to the structured facts. Currently they're stored as a flat table with just fact name and fact data fields. The question is, do we try to replicate this (hard, but not impossible), or do we flatten the structure? There is --show-legacy which will get all the 'old' facts out, but this is a sticking plaster so we might as well fix it now.

With flattening, I was thinking something like:

$ sudo /opt/puppetlabs/bin/facter --puppet --yaml system_uptime
system_uptime:
  days: 0
  hours: 0
  seconds: 1242
  uptime: 0:20 hours

Would be stored as:

system_uptime->days = 0
system_uptime->hours = 0
system_uptime->seconds = 1242
system_uptime->uptime = 0:20 hours

That delimiter was chosen arbitrarily, but it needs to be something odd enough to not likely be in a fact name. Flattening would make it easier to be backwards compatible with 3.8, since we can use the same table and just handle this in python. If we do something else, we'd need to re-wire the tables (which also makes all the existing plugins that use that info out of date).

[arubdesu]

It was odd to learn I couldn't classify based on structured facts in the PE console, so all I have in the way of custom facts right now are flat, anyway. Especially with the rise/integration of osquery I don't think it's worth reinventing the wheel over, table-wise.
As for a delimiter, how about the hash rocket? =>

[grahamgilbert]

This is fixed in the client side scripts