Comments (2)
This issue has been linked to a new work item: W-12586787
from pwa-kit.
Are you seeing a difference in the SDK version you generated your project with and the one you reported this issue on? The way errors are handled is very different when you are talking about a routing match and throwing them in render or getProps.
I tried generating a project with version 2.2.0
and it behaved the same to our latest 2.7.0
version. I'm only asking so I know to treat this as a regression/bug or a request.
A side note. The template-retail-react-app
was created as a starting point for developing your storefront, and we didn't implement customized error handling for pages like product-detail or product-list. As a result we simply throw and error and let the catch all error handler do its thing. We expect that project implementors would handle product not found errors in a customized way. For example, if you want the behaviour of retaining the app "chrome", you can remove the throw logic from get props and instead render a custom error component in the render portion of the product-detail page.
Anyway.. looking forward to hearing back from you, and we can discuss this more. 👍
from pwa-kit.
Related Issues (20)
- [BUG] Support Non-ASCII characters in HTTP Request Header Values HOT 3
- [FEATURE] Add support for hi-res / medium images to image gallery HOT 2
- [BUG] v3.5 - Duplicate subpath in request to get oauth token HOT 1
- [FEATURE] Add Sitemap handling HOT 2
- [FEATURE] Shopper Context Integration
- [BUG]Out of stock products should also be considered as unavailable products and be removed from cart and checkout page HOT 1
- [BUG] Seo component not setting keywords meta tag HOT 3
- [BUG] Cannot use import statement outside a module HOT 10
- [BUG] Missing onContextChange callback for version 2.8 HOT 1
- [FEATURE] Allow multiple MRT environments to share a single domain
- [FEATURE] Support Maintenance Mode 🚧 HOT 1
- [BUG] Custom parameters not taking into account for cache invalidation HOT 2
- [FEATURE] Identify traffic coming from MRT HOT 1
- [FEATURE] withReactQuery - add an option to seed the queryClient or to prefetch query HOT 3
- [BUG] Duplicated request for async/defer scripts using react-helmet HOT 3
- [BUG] Unsupported engine on NodeJS 22, NPM 10 HOT 1
- [DOCS] Examples of extending webpack configuration HOT 1
- [FEATURE] Support multiple `siteAliases` for a B2C Commerce Site HOT 1
- [FEATURE] Harden token handling
- [FEATURE] Support Agent Login 👔
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pwa-kit.