Coder Social home page Coder Social logo

Comments (2)

git2gus avatar git2gus commented on July 17, 2024

This issue has been linked to a new work item: W-12586787

from pwa-kit.

bendvc avatar bendvc commented on July 17, 2024

Hi @MykolaShkut-melon

Are you seeing a difference in the SDK version you generated your project with and the one you reported this issue on? The way errors are handled is very different when you are talking about a routing match and throwing them in render or getProps.

I tried generating a project with version 2.2.0 and it behaved the same to our latest 2.7.0 version. I'm only asking so I know to treat this as a regression/bug or a request.

A side note. The template-retail-react-app was created as a starting point for developing your storefront, and we didn't implement customized error handling for pages like product-detail or product-list. As a result we simply throw and error and let the catch all error handler do its thing. We expect that project implementors would handle product not found errors in a customized way. For example, if you want the behaviour of retaining the app "chrome", you can remove the throw logic from get props and instead render a custom error component in the render portion of the product-detail page.

Anyway.. looking forward to hearing back from you, and we can discuss this more. 👍

from pwa-kit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.