[QUESTION] About optional outputDir about pwa-kit

[bendvc]

Hi @gokaygurcan

Its hard to answer why that decision was made, would hazard a guess and say that it was probably the easier thing to do since the template id is a known value and therefore we would not have to do any validation to ensure proper folder creation.

For example if you name you project something like @my-company/e-comm-storefront there would be obvious issues creating a folder by that name or extra work. This is were the outputDir option came in.

That all being said, this isn't what I would classify as a bug so changing the behaviour would have to wait for a next major version bump if we were to accept this as work we want to do. I'd simply recommend that you user the outputDir option as it seems to do what you need it to do.

I'll wait for your response. Thanks

[gokaygurcan]

Hi @bendvc,

Thank you for your answer.

True, I agree, it doesn't feel like a bug, but bug template was a better option than feature request or security issue purely because of the structure. I don't have any timeline or immediate request to publish any update before the next major release.

With that said, it's just confusing. CLI should be useful and helpful, instead of only focusing on the least amount of keystrokes. I asked this question to understand the reason behind. If it's about keeping the keystrokes minimum, I'd argue against, but if it was just a result of evolution and sporadic updates on the file, that's more understandable and maybe something we can agree to improve over time.

I hope this gives more context.

[bendvc]

Thanks for the context @gokaygurcan I've added this to an to an internal doc to track improvements for next major release. For the time being i'm going to close this as it's strictly speaking not an issue/bug. We are accepting PR's if this is something that you are passionate about seeing in the next release and I can work on reviewing that for you.