Comments (8)
This is a bit more involved than I thought. We need to compile protostan's tests without relying on Stan's makefile. In principle people using protostan will be working with a different Stan tree and will not have libstan.a on hand (I think this is right).
from protostan.
Could you explain why this is tied up with Stan's makefile? I don't see the connection to not using
"stanc" as a name.
from protostan.
There's a rule in the Makefile which uses libstanc.a -- I'm pretty sure this is an artifact which is there for cmdstan from the days when cmdstan was part of the stan repo. I may be wrong about this.
from protostan.
I thought PyStan would also need to do the compilation required to make something like libstanc.a, no? Do you really recompile everything for every model?
from protostan.
PyStan compiles a hybrid Python/C++ thing for compilation separately.
When models are compiled they don't need to use the stan/lang stuff.
For testing I think it makes sense to leave libstanc.a the way it is.
But I do think it's a good idea to replace 'stanc' with 'compile'
elsewhere. That's the function signature after all. Without knowledge of
cmdstan I think 'stanc' doesn't have a clear reference.
On 01/04, Krzysztof Sakrejda wrote:
I thought PyStan would also need to do the compilation required to make something like libstanc.a, no? Do you really recompile everything for every model?
Reply to this email directly or view it on GitHub:
#18 (comment)
from protostan.
Ok, works for me. I can take care of it, I think there's some proto
file/c++ namespace issue involved.
On Jan 5, 2016 9:04 AM, "Allen Riddell" [email protected] wrote:
PyStan compiles a hybrid Python/C++ thing for compilation separately.
When models are compiled they don't need to use the stan/lang stuff.For testing I think it makes sense to leave libstanc.a the way it is.
But I do think it's a good idea to replace 'stanc' with 'compile'
elsewhere. That's the function signature after all. Without knowledge of
cmdstan I think 'stanc' doesn't have a clear reference.On 01/04, Krzysztof Sakrejda wrote:
I thought PyStan would also need to do the compilation required to make
something like libstanc.a, no? Do you really recompile everything for every
model?
Reply to this email directly or view it on GitHub:
#18 (comment)—
Reply to this email directly or view it on GitHub
#18 (comment).
from protostan.
I've got a PR ready, let me send that.
from protostan.
Ok
On Jan 5, 2016 9:39 AM, "Allen Riddell" [email protected] wrote:
I've got a PR ready, let me send that.
—
Reply to this email directly or view it on GitHub
#18 (comment).
from protostan.
Related Issues (20)
- Add cpplint test to travis CI
- Include path for generated (from .proto) cpp files is wrong HOT 2
- Makefile should assume user has protoc in path HOT 5
- Minimal example C++ project HOT 4
- Add .proto spec. for output format HOT 5
- Rename model_code to program_code, model_name to program_name, etc.
- POC: cmdstan-protostan HOT 3
- First writer HOT 8
- Figure out namespaces HOT 3
- Binary protobuf writer HOT 11
- Google C++ style HOT 2
- Remove protobuf source from repository (or whatever is making cloning slow) HOT 7
- License? HOT 2
- Document binary format and usage implied by the binary protobuf writer HOT 1
- Add a binaryProtubufFileWriter HOT 14
- Clean up mess from binary protobuf writer
- Simplify Makefile HOT 1
- Fix Makefile to allow for clang to be used
- C++11 on travis? HOT 1
- Use gRPC HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from protostan.