Comments (4)
I saw that but kept it in just to stick with monkeying the Stan C++ API. I think it's worthwhile to not make these changes at the interface wrapper level so I disagree with dropping it. Renaming it to match the Stan C++ API argument name makes sense. I should probably stick to that in the proto files.
from protostan.
Sounds good. I think we also should express the default value then. I gather this isn't done explicitly in protobuf 3, https://developers.google.com/protocol-buffers/docs/proto3#default
So I guess we check if in_file_name
(the renamed model_file_name
) is the empty string and, if so, make it "input".
from protostan.
Yes, protobuf is optimized for transmission so with optional fields the default values are encoded in the interfaces rather than sent on the wire. The only user-configurable default is ENUMs where the first option (0) is taken as the default and you can give it a meaningful value... of course in that case you can't tell if it's the default value because it was set or because it was not set so it better really be a good default meaningful value.
from protostan.
Closing in favor of #19
from protostan.
Related Issues (20)
- Add cpplint test to travis CI
- Include path for generated (from .proto) cpp files is wrong HOT 2
- Makefile should assume user has protoc in path HOT 5
- Minimal example C++ project HOT 4
- Add .proto spec. for output format HOT 5
- Rename model_code to program_code, model_name to program_name, etc.
- POC: cmdstan-protostan HOT 3
- First writer HOT 8
- Figure out namespaces HOT 3
- Binary protobuf writer HOT 11
- Google C++ style HOT 2
- Remove protobuf source from repository (or whatever is making cloning slow) HOT 7
- License? HOT 2
- Document binary format and usage implied by the binary protobuf writer HOT 1
- Add a binaryProtubufFileWriter HOT 14
- Clean up mess from binary protobuf writer
- Simplify Makefile HOT 1
- Fix Makefile to allow for clang to be used
- C++11 on travis? HOT 1
- Use gRPC HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from protostan.