could we make Instagram.createInstagramObject() protected instead of private about jinstagram

[sachin-handiekar]

Ok. I'll make the method protected.

Which other methods do you think will be helpful for the extension ?

[pbvahlst]

Great, thanks

I have made some modifications through inheritance which could go into Instagram.java

generic way to create new objects, makes it easy to create your own model. This method don't need reflection when it can access the createInstagramObject method.

@SuppressWarnings("unchecked")
public <T extends InstagramObject> T fetchObject(String path, Class<T> type, Parameter... params) throws InstagramException {
    Map<String, String> paramMap = new HashMap<String, String>();
    for (Parameter p : params) {
        paramMap.put(p.getKey(), p.getValue().toString());
    }

    T result = null;
    try {
        result = (T)createInstagramObjectMethod.invoke(this, Verbs.GET, type, path, paramMap);
    } catch (InvocationTargetException e) {
        if (e.getCause() != null && e.getCause() instanceof InstagramException) {
            throw (InstagramException)e.getCause();
        } else {
            throw new RuntimeException(e);
        }
    } catch (IllegalAccessException | IllegalArgumentException e) {
        throw new RuntimeException(e);
    }

    return result;
}

A generic getNextPage method

@SuppressWarnings("unchecked")
public <T extends InstagramObject> T getNextPage(Pagination pagination, Class<T> type) throws InstagramException {
    T result = null;
    try {
        result = (T)createInstagramObjectMethod.invoke(this, Verbs.GET, type, StringUtils.removeStart(pagination.getNextUrl(), getInstagramConfig().getApiURL()), null);
    } catch (IllegalAccessException | IllegalArgumentException | InvocationTargetException e) {
        throw new RuntimeException(e);
    }
    return result;
}

Finally it would be nice if the generics in the model objects such as List<MediaFeedData> data was parameterized with a wildcard so we get List<? extends MediaFeedData> data. This will make the extension of the existing model possible. (the getters and setters should also have ? extends XXX)

[sachin-handiekar]

Closing the ticket... Re-open if needed