The bookstore from sabondano

bookstore's People

Contributors

Watchers

bookstore's Issues

Your views regarding calling author_name in book

Hi,
I was working with developing the exact bookstore application with same requirement for terakeet interview. I bumped in to your code after submission and saw you were calling

def author_name
    "#{author.first_name} #{author.last_name}"
end

in the Book class itself.

I wanted to ask for your views of why should book class be responsible for handling author's name ? Doesn't it violate the OOP concepts ? Should not author class handle it OR book class should delegate it to the author class ? Both do the same number of queries.

class Book < ApplicationRecord
  belongs_to :author

  def author_name
    get_author_name(self.author_id)
  end
  def author_name2
    "#{author.last_name} + #{author.first_name}"
  end

  private

  #minimizing class dependecies by providing private methods as external interfaces
  def get_author_name(author_id)
    Author.get_author_name_from_id(author_id)
  end

end

class Author < ApplicationRecord
    has_many :books

    #class methods which provides a gate-way for other classes to communicate through interfaces, thus reducing coupling.   

    def self.get_author_name_from_id(id)
        author = self.find_by_id(id)
        author == nil ? "Author Record Not Found" : "#{author.first_name.titleize} #{author.last_name.titleize}" 
    end

end