animation failed if changed from one filtervalue to another about angulargrid

[vollyimnetz]

I found a quick-fix,
change

//get all list items new height
var item, $item, clone;
for (i = 0, ln = listElms.length; i < ln; i++) {
    item = listElms[i];
    $item = single(item);

    //create clone of item to calculate proper height
    clone = $item.clone();
    clone.addClass('ag-no-transition');
    clone.css('width', colWidth + 'px');
    $item.after(clone);

    listElmHeights.push(clone[0].offsetHeight);
    clone.remove();
}

to

//get all list items new height
var item, $item, clone;
for (i = 0, ln = listElms.length; i < ln; i++) {
    item = listElms[i];
    $item = single(item);

// ##########################################
    //define defaultValues if not set
    var reset = {
        top:'0px',
        lef:'0px'
    };
    if($item.css('top')==='auto') {
        $item.css(reset);
    }
// ##########################################

    //create clone of item to calculate proper height
    clone = $item.clone();
    clone.addClass('ag-no-transition');
    clone.css('width', colWidth + 'px');
    $item.after(clone);

    listElmHeights.push(clone[0].offsetHeight);
    clone.remove();
}

That looks a little bit better. But it would be great if we have also animations when elements are leaving the array - don't know if there is any event one can hook into.

[s-yadav]

Thanks vollyimnetz, for providing great explanation for your issue.

There is problem with filter, as ng-repeat does not trigger any event when element added or removed (there is scope watch, but will not help with this specific problem), and also it will not wait for the leaving element to complete animation, and removes them from DOM,
I guess the proper solution will be to have custom repeat directive for the plugin, and check for model changes and listen transitionend event, for smooth transition.

I will try experimenting for the solution of this problem, it may take some time as I am quite busy with other projects, but I will try to fix this as soon as possible.

[s-yadav]

Hi vollyimnetz,
Check for the latest commit, It included animation support using ngAnimate module,
Check demo on http://ignitersworld.com/lab/angulargrid/