Express 5 Support? about bull-monitor

[s-r-x]

@robincsamuel hello, looks like apollo-server-express doesn't support express 5 (and it's still in alpha btw) so i'm closing this for now

[robincsamuel]

I tried to debug the issue and figured out the root cause. It works fine if I pass bodyParserConfig: false to the applyMiddleware method (source). However, I don't see a way to pass this config via bull monitor.

@s-r-x Any idea?

[robincsamuel]

It's currently in beta, fyi :)

[s-r-x]

that's cool

[robincsamuel]

Adding a middleware like this fixes the issue since body-parser checks for req._body to see if it's already parsed and skips parsing in that case.

router.post('/queues/graphql', (req, res, next) => {
      req['_body'] = true;
      return next();
});

I think it'd be great if we can pass the Apollo Server/applyMiddleware options via bull monitor configuration. I'd be happy to raise a PR if you think that's a good idea :)

[s-r-x]

@robincsamuel n1. I think we can add some config to the init method with something like express5: boolean, and tweak bodyparserconfig based on that. wdyt?

[robincsamuel]

Yeah, that'd work. But I think accepting the apollo server's acceptMiddleware options would be a more robust solution. Because that'd probably be helpful in many other cases where someone can pass in a custom body parser configuration or even cors configuration.

[s-r-x]

I don't want to let the library users to deal with any internal dependency (like apollo server) directly, so let's stick with some abstraction for now

[robincsamuel]

Okay, that makes sense. What about passing a more generic option like disableBodyParser and disableCors? I think a flag based on the express version may become irrelevant in the future or will end up adding more flags.

Or maybe, we can detect the express version and handle this without a flag.

[s-r-x]

sounds good

[robincsamuel]

so, which method do you think is the best? disableBodyParser flag or detect the express version and handle based on that?

[s-r-x]

both are fine, do whatever you think fits the best