Themed trophies not updating about github-profile-trophy

[ryo-ma]

I don't understand the problem. Can you explain a little more concretely?

[gabrielconlon]

This may honestly be on GitHub's end, but there seams to be an issue that certain themes are not updating or it is taking a very long time (hours to days). For instance, up above I had the darker theme on my RREADME.md and noticed the total repositories and commit's numbers did not match my GitHub stats. but with the default light theme, the numbers updated.

This was both embedded in the README.md and again in a separate browser window. I am having the same issue with anuraghazra's readme-stats repository GitHub-README-stats as well now, which leads me to wonder I this is just lag on GitHub's end.

Sorry for the confusion

EDIT: added screenshot to see the discrepancy with GitHub-stats
I've tried adding a second trophy block with theme applied to see if I can reproduce the issue as above. I'll capture the code this time as well if I catch it

[ryo-ma]

I think it's probably a cache issue. When the theme changes, the URL changes, so the cache also changes.

Currently, the cache max-age is set to 2 hours.

github-profile-trophy/index.ts

Line 81 in 522489b

"Cache-Control": `public, max-age=${CONSTANTS.CACHE_MAX_AGE}`,

About cache:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control