Zero bytes about ytdl

[schollz]

I am also seeing this. I can add a little more info.

I am using this library with getsong and I have a TravisCI cron job to test it daily. I've been getting daily build errors since 06/05/2019 on the same commit (d71b9ef8) which is a commit that is over 8 weeks old.

I have some logs and this is what I see when it errors:

2019-06-05 19:09:59 [DEBUG] getsong.go downloadYouTube:192 downloading https://r1---sn-vgqskn7e.googlevideo.com/videoplayback?c=WEB&clen=3884052&dur=218.721&ei=hhP4XMCpOpTbNvXXo-gE&expire=1559783399&fvip=1&gcr=us&gir=yes&id=o-AKPffesLG3FdY60IpiLYkR4ugslA9xKiPRMvBlCBjZCk&initcwndbps=4952500&ip=35.188.1.99&itag=251&keepalive=yes&lmt=1533732061734022&lsig=AHylml4wRAIgMOo0Zsu-UluvU0RGgDqbF6VlS5DWVsqaNp4Evu7LGosCIGYyS0W0YubVmYGYw30tDrBewYSZwGY4fajE7CHPVRgw&lsparams=mm%2Cmn%2Cms%2Cmv%2Cpl%2Cinitcwndbps&mime=audio%2Fwebm&mm=31%2C29&mn=sn-vgqskn7e%2Csn-vgqsrn7d&ms=au%2Crdu&mt=1559751098&mv=m&pl=20&ratebypass=yes&requiressl=yes&signature=ALgxI2wwRQIgVimHksAkYAakM-tSG8n4s1QsgWJMiOUUGFOcz6ttbvgCIQDTZ4V9T1J0X0NQtpd2sglByGivBoxqkjjKHiM0nAs7YQ%3D%3D&source=youtube&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cgcr%2Cmime%2Cgir%2Cclen%2Cdur%2Clmt 
2019-06-05 19:09:59 [DEBUG] getsong.go DownloadFromYouTube:215 total length: 0 
...converting to mp3...
--- FAIL: TestGetSongAPI (1.57s)
    getsong_test.go:19: 
        	Error Trace:	getsong_test.go:19
        	Error:      	Expected nil, but got: could not convert video: exit status 1
        	Test:       	TestGetSongAPI

Basically its showing that it gets a good URL but that it downloads zero bytes. Eventually an error is thrown in my program because it tries to convert a file that is empty and then the Travis test fails.

I've seen that this problem is not consistent. I fixed my program by just re-trying grabbing the YT URL if it does fail with getting a zero-length file, because sometimes it does not get a zero-length file. Its weird.

[sula7]

I tried to use this repo in OS windows (7, 10) and different hardware and I've got 0 byte files. When I tried to use it in linux (ubuntu 18.04), it works properly. Golang ver 1.12.6 in all PCs.
@rylio maybe need to test and write to readme that this works only in linux?

[danackerson]

see #70 - Youtube changed API to use ?sig= instead of ?signature=

[corny]

This necessary change has been pushed into the master branch.