Bug: Player easily falls out-of-bounds about basque

[ryanpcmcquen]

I think I can temporarily deploy your branch using GitHub actions and test it here, won't have time for a few days though ...

[ryanpcmcquen]

Yep, this is already solved in the closed source version of the engine as seen on the Twitch streams, but fixing it here is tricky while staying under 1000 lines.

[fontire]

Is there a need to stay < 1000 lines? It's a nice number but having the engine more useful seems like a better goal.

[ryanpcmcquen]

I'd rather make a 'Basque+' or something similar when the game is done with a host of improvements. I think the 'under 1000 lines' rule keeps it mentally manageable for people who are just getting into C99 and whatnot.

[fontire]

Okay. Incidentally, I don't think that an UP/DOWN event combo in SDL2 has delay/repeat issues when storing the state (as in the changes in my fork).

The DOWN event triggers the state immediately and that is retained until the UP state (also immediate). Any delayed/repeated DOWN events have no effect on the state.

[ryanpcmcquen]

Would you be willing to test the WASM port with these changes? I remember touch controls being weird there before scancodes.

[fontire]

Perhaps. I don't think I'm set up for that, though.

[ryanpcmcquen]

@fontire will you make a PR here?