Not explicit function name about clean-code-javascript

[ryanmcdermott]

You know what, you're right. It should say showEmployeesList! Want to make a PR?

[AnnaNee]

Sure!

[hueitan]

The other examples give

showDeveloperList without (s)
showManagerList without (s)

and now we use showEmployeesList with (s)

which is the best case?

[AnnaNee]

Haven't thought about that. I usually use in the plural form when a certain method has many properties as a result, so showEmployeesList(). But to talk about the best practices I can't say which is better. In the other hand, in order to keep consistency, I think we should change to showEmployeeList().

What you think?

[ryanmcdermott]

This gets into a bit of linguisitics, which is off in the weeds away from Clean Code, but a noun pre-modifier is usually singular: Grocery List, Customer List, Client List, etc. I think showEmployeeList would be both consistent with the document and with the language 🤓 I could be comfortable with either, but let's just make it consistent then. Thanks for putting so much time into picking good names! Half of programming skill is about naming and organization.

[hueitan]

Half of programming skill is about naming and organization.

😂 indeed.

I also agree with either, as long as your team approve with the naming.

[AnnaNee]

I'll change it to showEmployeeList() then. Thanks @hueitan for pointing that out. ;)