Comments (10)
hmm... I didn't use mocha before ... but if it's just a testing library ... I can move it to devDependencies or remove it altogether as I added jest. I'll have to fix scripts also.
BTW the old version mocha was the one causing the critical vulnerability. so, I had to do this major upgrade.
Yeah old mocha has security complaints in this repo as well but within the example project folders 😅. Ping me once the PR is up to swap out the dependency with yours and I can get the CI workflow running against it for yeah.
from vscode-coverage-gutters.
@7sean68 Thanks again for helping maintain and enhance the extension!
This will go out in the 2.11.0 release (shouldn't be more than a couple weeks as I will descope some of the items to allow for this to go out quicker).
from vscode-coverage-gutters.
@7sean68 Thanks for the ticket!
Most likely, we will need to fix this in the jacoco upstream dependency 🤔.
https://www.npmjs.com/package/jacoco-parse
It seems like the project is not maintained anymore though and someone will have to look for a more up-to-date fork or do the fix in a fork themselves.
from vscode-coverage-gutters.
I searched but couldn't find a suitable fork ... I can create a fork and implement this in it then publish it on npm. will you be willing to use it?
from vscode-coverage-gutters.
I forked it to
https://www.npmjs.com/package/@7sean68/jacoco-parse
and added support for group tag keeping all backward compatibility.
also I fixed some vulnerabilities including 1 critical.
from vscode-coverage-gutters.
I forked it to https://www.npmjs.com/package/@7sean68/jacoco-parse
and added support for group tag keeping all backward compatibility. also I fixed some vulnerabilities including 1 critical.
Looks great, thanks for taking this on!
If you can setup a PR against the extension, I will do a review of the new forked dependency and we can see if all the tests pass in the CI workflow.
from vscode-coverage-gutters.
@7sean68 Only initial minor issue I see (after looking through vokal/jacoco-parse@master...7sean68:jacoco-parse:master#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R21), is that the repo has mocha as a dependency rather than a dev one? (this isn't something you did with the fork and I am not sure the lift to move that into a dev dependency instead?)
Nice job with the fork and the extra test coverage though! 👍🏻
from vscode-coverage-gutters.
hmm... I didn't use mocha before ... but if it's just a testing library ... I can move it to devDependencies or remove it altogether as I added jest. I'll have to fix scripts also.
BTW the old version mocha was the one causing the critical vulnerability. so, I had to do this major upgrade.
from vscode-coverage-gutters.
@ryanluker
can you check this PR #405 ?
from vscode-coverage-gutters.
@ryanluker can you check this PR #405 ?
Sure thing!
Took a first look and left one comment, otherwise looking great to me (especially the added example + test coverage! thanks a bunch for htis).
from vscode-coverage-gutters.
Related Issues (20)
- Extension settings do not have the scope property defined HOT 3
- refactoring if clause caused extension to crash HOT 3
- update CHANGELOG.md to make changes extension-visible
- Java example pom issues and failure in mvn install HOT 2
- Cannot seem to watch files outside of VS Code workspace directory HOT 2
- Improve visibility of covered lines HOT 4
- Add support for remote coverage files HOT 3
- Support coverage reports with multiple sources HOT 2
- behavior change suggestion/rfc: statusbar should report `Math.floor` instead of `Math.round` HOT 1
- `Illegal argument: line must be non-negative` when any `detail.line` is 0 HOT 1
- Where does the watcher look for the lcov.info file? HOT 2
- Coverage information fails to render when branch coverage is enabled HOT 1
- Update deploy automation action to use v1 of external action
- Cant read coverage data from cobertura-coverage.xml HOT 1
- Don't highlight tested lines HOT 4
- vsix packaging: drop unused folders HOT 1
- cobertura Status Bar Percentage Wrong with C# Workspace HOT 6
- Attempting to parse cobertura.xml fails after converting from visual studio .coverage binary. HOT 2
- settings: resolve configuration settings HOT 1
- [Documentation] Example Java Gradle Project HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vscode-coverage-gutters.