Comments (4)
@SethFalco Thanks for the ticket!
Definitely would be better to turf the on startup instantiation of this extension (this was the only option when I initially developed it, I think...).
I like both ideas, but I think it is reasonable to only load the extension if an applicable file is found. I do wonder about how we might consider other file types not defined in the default list.
https://github.com/ryanluker/vscode-coverage-gutters/blob/master/package.json#L129-L135
from vscode-coverage-gutters.
I do wonder about how we might consider other file types
Unfortunately, I don't think VSC has a way to change activation based on settings, so if you're expecting users to specify additional files that are not info.lcov
or **/*.xml
, then the only option would be onStartupFinished
I think. 🤔
Some other extensions have a similar issue, for example SonarSource/sonarlint-vscode, prettier/prettier-vscode, and microsoft/vscode-eslint could just specify to only activate on the list of officially supported languages, but users can also have plugins/projects/settings that define or target other languages, so even if it's not too often, they need to use onStartupFinished
instead.
Fine with using onStartupFinished
at least, though?
from vscode-coverage-gutters.
@SethFalco Agreed that onStartupFinished
sounds like a good first step!
Thanks for the links to over extensions as well, it looks to be the norm to use this event instead which is nice to keep inline with the community 👍🏻.
from vscode-coverage-gutters.
@SethFalco Thanks again for the contribution and the PR, the change should go out in 2.11.0
from vscode-coverage-gutters.
Related Issues (20)
- Extension settings do not have the scope property defined HOT 3
- refactoring if clause caused extension to crash HOT 3
- update CHANGELOG.md to make changes extension-visible
- Java example pom issues and failure in mvn install HOT 2
- Cannot seem to watch files outside of VS Code workspace directory HOT 2
- Improve visibility of covered lines HOT 4
- Add support for remote coverage files HOT 3
- Support coverage reports with multiple sources HOT 2
- behavior change suggestion/rfc: statusbar should report `Math.floor` instead of `Math.round` HOT 1
- `Illegal argument: line must be non-negative` when any `detail.line` is 0 HOT 1
- Where does the watcher look for the lcov.info file? HOT 2
- Coverage information fails to render when branch coverage is enabled HOT 1
- Update deploy automation action to use v1 of external action
- Cant read coverage data from cobertura-coverage.xml HOT 1
- Don't highlight tested lines HOT 4
- vsix packaging: drop unused folders HOT 1
- cobertura Status Bar Percentage Wrong with C# Workspace HOT 6
- Attempting to parse cobertura.xml fails after converting from visual studio .coverage binary. HOT 2
- settings: resolve configuration settings HOT 1
- [Documentation] Example Java Gradle Project HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vscode-coverage-gutters.