Comments (5)
That makes sense. It should only copy those resources if OpenCanopy is enabled except for maybe the startup chime, pretty sure you can have that without OpenCanopy
I'll need to check for chime being enabled, but probably not voice over, I think that would only make sense with OpenCanopy
from oc-tool.
This should take care of it. I think the last change to Resources was the addition of the Label folder, the user should at least get some kind of warning now if they have OpenCanopy enabled but are missing resources.
Now it will only copy them if OpenCanopy is enabled, or it will only copy Audio if they only have PlayChime enabled.
from oc-tool.
I know I had a reason for them being in INPUT instead of extras, but I don't remember exactly what it was. I made that change back in March. Something to do with wanting to keep extras as a folder that overrides all versions, even if something newer exists.
Anyways, thanks to your suggestion, it now only copies them if OpenCanopy is enabled instead of always copying them no matter what. Thanks.
from oc-tool.
Most folks will leave their "Resources" folder ready with all they need, so it is another "set it and forget it" kind of folder. Not sure how often OpenCanopy changes that requires the resources to be updated, but I suspect this will be a very low incidence. To keep it simple, I would think a simple copy - as you do with any non-acidanthera kext file - should suffice. And yes, "if OpenCanopy.efi then copy extra/Resources; if extra/Resources not found, warn user". This should also help with the signing and vault (hint hint on positioning of the copy process :D)
from oc-tool.
What's the rationale of the Resources being looked for on "INPUT" folder instead of the "extras"?
from oc-tool.
Related Issues (20)
- OC-tool cannot build codeless BrcmBluetoohInjector HOT 2
- Unable to build OpenCorePkg RELEASE from source but building DEBUG works HOT 4
- cannot deal with pipe symbol in comments ;-)) HOT 3
- OpenCorePkg HOT 1
- [Bug]Stuck downloading Hfs.plus HOT 2
- OpenHfsPlus.efi is not recognized as a built-in binary HOT 4
- [Bug] ERROR: build failed for Lilu HOT 9
- Missing </dict> </plist> at end of plist HOT 2
- [Bug] Error HOT 2
- Thank You HOT 1
- Does it update config.plist? HOT 1
- Add support for BlueToolFixup kext off BrcmPatchRAM HOT 2
- [Bug] Not updating to 0.7.1 HOT 4
- OC-tool producing boot0af error HOT 4
- Five return errors HOT 3
- build failed for IntelMausi HOT 6
- OpenCanopy.efi issues HOT 2
- not all EFI drivers loaded in 0.7.3 release HOT 6
- OpenLinuxBoot.efi - no prebuilt found for OpenLinuxBoot.efi HOT 1
- Driver folder missing HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oc-tool.