Coder Social home page Coder Social logo

Comments (3)

daxpedda avatar daxpedda commented on September 23, 2024 1
  • it's modifying the DOM adding a style property, but it's not allowing to remove it (something like "reset_cursor_icon" or "remove_cursor_icon")

Making CursorIcon::Default remove the cursor style is probably the way to go. Though it would be best if we can figure out how to make this behave the same cross-platform, e.g. does Default fall back to the default cursor on other backends as well? If it does, shouldn't we add a Cursor one as well then?

I will ask around and then open a separate issue.

  • it's missing some possible values, so adding them could work as well.

It would be best if you point out exactly what you are missing so we can figure out if its covered by other backends as well or if its a Web-only thing.

NB: I can help, but I don't know the main vision so I don't want to implement something that's not going to be accepted (especially since the new 0.30 revamp).

We have to figure out first how we want to proceed before doing any implementation.

from winit.

daxpedda avatar daxpedda commented on September 23, 2024

What would you want Winit to do here?
You can use !important to overwrite Winit, after all Winit itself isn't doing anything special, just adding CSS directly to the element.

I'm going to close this as not really actionable, but please feel free to make a suggestion here if you have one.

from winit.

beoboo avatar beoboo commented on September 23, 2024

I think one of these 2 solutions could really help:

  • it's modifying the DOM adding a style property, but it's not allowing to remove it (something like "reset_cursor_icon" or "remove_cursor_icon")
  • it's missing some possible values, so adding them could work as well.

Even if we can set !important on the parent, this doesn't seem the proper solution.

IMHO implementing both the above missing parts would be the perfect and more robust solution.

NB: I can help, but I don't know the main vision so I don't want to implement something that's not going to be accepted (especially since the new 0.30 revamp).

from winit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.