Coder Social home page Coder Social logo

Comments (3)

YuhanLiin avatar YuhanLiin commented on July 30, 2024

A back-compatible way of adding this would be to add something like

pub trait Predict<R: Records, T> {
    ...
    fn predict_into(&self, x: R, out: &mut T) {
         *out = self.predict(x);
    }
}

which would be overridden for a more efficient implementation. This isn't really useful if T is a Result, however.

from linfa.

pYtoner avatar pYtoner commented on July 30, 2024

Do we want to handle invalid target shapes like:

fn predict_inplace<'a>(&'a self, x: &'a R, y: &mut T) -> Result<(), InvalidTargetShape>

Or with a more generic error? Is it just a shape mismatch that we want to handle like this?

from linfa.

YuhanLiin avatar YuhanLiin commented on July 30, 2024

We should have a PredictError enum that has InvalidTargetShape as a variant. The error type will only contain error variants that makes sense to panic on. For now we only care about shape mismatches.

from linfa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.