Comments (2)
Making logs available is not a problem, they shouldn't ever contain anything that can't be found publicly on GH, and I don't see any danger from aggregation here.
We plan to move Highfive to some Rust project infra rather than my personal server. Though this has been stalled for quite a while now.
I expect we won't want to hand out creds to that server, however, shipping the logs elsewhere seems fine. I guess from a user perspective it would be better to pull logs, rather than push them on a regular basis. I have no idea how to engineer that.
When debugging Highfive, the most useful logs I have looked at have not come from Highfive, but from the GitHub web-hook. I'm not sure how or if we can make those available, but I expect that is what we really want.
from highfive.
I expect we won't want to hand out creds to that server
I completely understand that. Is the concern about giving non-Mozilla access to the machine, the @rust-highfive OAuth token, or both? I could pretty quickly put Highfive on an EC2 instance that is only for Highfive, although that would give me "leverage" that might be a little strange. If I did that, though, there wouldn't be an immediate incentive to engineer a way to give access to logs, but for that to work, the @rust-highfive token would need to be on the machine. 😬
Incidentally, I've been harboring a secret desire to turn Highfive into a GitHub app. I was waiting for the right time to propose this, but it's relevant here because it would eliminate the need for the @rust-highfive token. I could go into more details (I actually started writing a doc for you at one point), but the short version:
- It would allow non-Rust projects to use Highfive (Highfive would need changes to support this).
- It would also create some other work to generalize, but still allow customization (like having an outgoing webhook from Highfive to enable things like pinging on IRC).
This idea is way outside the scope of Rust's needs, of course, so I won't be shocked if your response is not enthusiastic. 😀 I just had to mention the possibility.
from highfive.
Related Issues (20)
- Add some local tests
- rust-highfive only warns about updated submodules when a PR is created HOT 4
- Remove jemalloc config
- `r? @rust-highfive` to reassign a review randomly (again) HOT 1
- naive startswith can cover wrong directories for "mentions" HOT 1
- directory choice only examines first two components HOT 1
- feature request: warn if src/test/ is modified without modifying compiler/ or src/librustdoc/ HOT 5
- Warn on change to targets HOT 1
- Please detect commits that mark an API as stable and display a warning
- highfive should not assign someone to their own PR HOT 3
- Warn when `r?`d username doesn't have `r+` rights
- Mention notifications for changes to subtrees HOT 8
- Add link to rustbot commands in first message
- Why is it written in Python? 👀 HOT 1
- Add repo link to the `rust-highfive` user account
- Update rust config to add wgs/projects
- Give helpful info with r? is invalid HOT 1
- highfives misses some PRs HOT 1
- no longer can assign specific users HOT 1
- Re-assigning can assign the current assignee HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from highfive.