Coder Social home page Coder Social logo

Comments (4)

nikomatsakis avatar nikomatsakis commented on September 26, 2024

cc @mikeyhew

cc @withoutboats -- do you think further changes are needd in coherence?

from chalk.

lqd avatar lqd commented on September 26, 2024

I'd like to try this if that's ok :)

@nikomatsakis to add the keyword to the parser, should we ensure #[auto] and #[marker] can or can't be used at the same time ? (maybe it doesn't matter).

Should we also add the #[marker] attribute to the other marker traits in the solver tests ? (the ones named Marker specifically, since most other tests are marker traits as well ?)

btw I quickly prototyped the steps in the issue, and indeed nothing more seems to be needed to solve the problem.

EDIT: In the meantime I've opened #64 as WIP with those questions

from chalk.

mikeyhew avatar mikeyhew commented on September 26, 2024

@lqd I was going to take this on, but I'm already busy with an issue from rust-lang/rust, and you seem to have a good idea of what needs to be done here, so go for it :) When I'm finished with the compiler issue, I'm sure @nikomatsakis will have more issues to work on for chalk.

#[auto] and #[marker] can both be used at the same time – think of Send and Sync. As for adding #[marker] to traits in the existing tests, that sounds like a good idea, but I'll let @nikomatsakis or @withoutboats direct you there. There is one test case though that I added in #61, partial_overlap_3, which currently doesn't pass, and should pass once you implement this and add a #[marker] attribute to the Marker trait.

from chalk.

lqd avatar lqd commented on September 26, 2024

@mikeyhew thanks for the comment ! As you mentioned, partial_overlap_3 indeed passes successfully with #64

from chalk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.