Adding Range of Circles about blazorgooglemaps

[valentasm1]

Since there is already working example "MarkerList" then you could make pull request with copy just for circles. It would be good to make more on inheritance and some abstractions if possible. If not you could copy paste functionality RenameAll "Markers"> "Circles" and done.

[turner11]

Thanks.
If this is all that is to it - I will give it a try.

[valentasm1]

Here is original PR but probably it will be hard to fallow :)
#52

[RobertoMilani]

I have a lot of issues with GitHub and Visual Studio 2019 preview (first of all, rebase doesn't work properly). It seems to me that it has now been resolved (I've checked each file is correctly synced with yours). Now, I can try to implements CircleList as done with MarkerList since there are not "strange type" used in Circle class, so I don't expect any particular problems Il giorno mer 29 lug 2020 alle ore 13:13 Valentas <[email protected]> ha scritto:

…

Here is original PR but probably it will be hard to fallow :) #52 <#52> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#59 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALCDRD6CBGFJK6ZYUQ6VO5LR57737ANCNFSM4PLI7RLA> .

--

[RobertoMilani]

I've prepared two pull requests for updated Circle class and new CircleList class. If they seems to you ok, I think - before implements other "Listeners" management inside classes and before implement eventually "SomethingList" classes - it's better to proceed with a little code re-engineering, creating base class with common code fragments to prevent "uncontrolled growth / cloning" of same code fragments inside classes. I'll start working on it if you agree. Il giorno dom 2 ago 2020 alle ore 10:28 Roberto Milani < [email protected]> ha scritto:

…

I have a lot of issues with GitHub and Visual Studio 2019 preview (first of all, rebase doesn't work properly). It seems to me that it has now been resolved (I've checked each file is correctly synced with yours). Now, I can try to implements CircleList as done with MarkerList since there are not "strange type" used in Circle class, so I don't expect any particular problems Il giorno mer 29 lug 2020 alle ore 13:13 Valentas < ***@***.***> ha scritto: > Here is original PR but probably it will be hard to fallow :) > #52 <#52> > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#59 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ALCDRD6CBGFJK6ZYUQ6VO5LR57737ANCNFSM4PLI7RLA> > . > --

--

[valentasm1]

Thank you for pull request. Will close issue in couple days if you wont close.
https://www.nuget.org/packages/BlazorGoogleMaps/0.6.13

[valentasm1]

Just saw you last comment.
I will do that if any issue will come related this functionality or will come SomeThingList (like you said).
If you have time and will i really appreciate your effort.

[RobertoMilani]

Thank you :) I've just done it! I'd like a double check by you, due the nature of changes. I'm testing now what I put inside the new pull request in my personal sites and all seems to be working without any evident issue. However, a thing I found inside the original Circle class implementation caused me a thought: there was an internal Map member inside class Now it has been removed to coherence with marker class, but... a) Yes, we have "real stateless" classes (no state is stored in any member, except - for expediency - the list of any listeners) b) On the other hand, this implies that any (any yes any) little thing we want to know about "state of the object" requires we perform a JSInteropt call with (in case of single call, otherwise SomeThingList class need to be used) a little effort in term of performance. It's a hard choice: RAM consumption e stateless advantages versus speed. In this release I adopted a "democratic approach" --> "majority wins" So, since _map is the only "state" member occurrence, I revolve it instead of adding all other members. It may be that I have "blindfolded eyes", but at the moment I don't see a so-called "third way". Do you have any ideas on this for any future implementations? See you soon :) Il giorno dom 2 ago 2020 alle ore 21:33 Valentas <[email protected]> ha scritto:

…

Just saw you last comment. I will do that if any issue will come related this functionality or will come SomeThingList (like you said). If you have time and will i really appreciate your effort. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#59 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALCDRDYS5SDRRUH6BNHS2HLR6W5PNANCNFSM4PLI7RLA> .

--

[valentasm1]

Are you talking about caching states somewhere?
In my experience with this solution only one time people complain about performance was when they need to add many items. Cases like yours. Looks like you have plenty of free time :D. If there is no problem then dont solve non existing problem. It is not corporate or payed software where all parts have to be cutting edge in all areas.
Personally i always try avoid working on this solution. Asking for pull request, forwarding resources. Only if there are no other option i will fix, so am not gonna help you with this case. If you want spend you time here your wellcome.

[RobertoMilani]

Sure, you are in right!
It's better to choose a "stateless" approach.
Oh, I work for an IT company that sell "day use" services for hotels, so, it depends, day by day... sometimes I work for more than ten hours by day, sometime I have more time for me :)
I try to help, expecially if I note something of "bad" but "solvable by me" so as something can help me too ;)

[RobertoMilani]

WAIT BEFORE MERGE PULL REQUEST

I just discovered a JS error... :(
I'll solve it, then add the fix

[RobertoMilani]

DONE

It was only a wrong reference to:
using System.Text.Json.Serialization;
instead of
using Newtonsoft.Json;

Now, with second pull request all seems ok :)

[valentasm1]

#64

[valentasm1]

https://www.nuget.org/packages/BlazorGoogleMaps/0.6.14

[valentasm1]

https://github.com/rungwiroon/BlazorGoogleMaps/releases/tag/0.6.14