Coder Social home page Coder Social logo

Comments (9)

valentasm1 avatar valentasm1 commented on August 12, 2024

control is not positioned as TOP_LEFT but as BOTTOM_CENTER. this is different bug. Not related to serialization. Solved with #281

from blazorgooglemaps.

cruiserkernan avatar cruiserkernan commented on August 12, 2024

I believe it is another bug. Upon running the Blazor Server Demo and examining the MapLegendPage, I observed that its intended position, TOP_LEFT, is not reflected in the actual placement; it appears at BOTTOM_CENTER instead. During debugging, I noticed that the addControl method in the objectManager is receiving "topLeft" as the enum value. However, this doesn't seem to match any case in the switch statement, causing it to revert to the default case of BOTTOM_CENTER.

I initially noticed this in my current application when trying to position the control on RIGHT_CENTER.

using System.Threading.Tasks;
using GoogleMapsComponents;
using GoogleMapsComponents.Maps;
using Microsoft.AspNetCore.Components;
using Microsoft.JSInterop;

namespace ServerSideDemo.Pages;

public partial class MapLegendPage
{
    private GoogleMap map1;

    private MapOptions mapOptions;

    [Inject] private IJSRuntime jsRuntime { get; set; }

    protected ElementReference legendReference { get; set; }

    protected override void OnInitialized()
    {
        mapOptions = new MapOptions()
        {
            Zoom = 13,
            Center = new LatLngLiteral()
            {
                Lat = 13.505892,
                Lng = 100.8162
            },
            MapTypeId = MapTypeId.Roadmap
        };
    }

    protected override async Task OnAfterRenderAsync(bool firstRender)
    {
        if (firstRender)
        {
            await jsRuntime.InvokeAsync<object>("initMapLegend");
        }
    }

    private async Task AfterMapInit()
    {
        await map1.InteropObject.AddControl(ControlPosition.TopLeft, legendReference);
    }
}

image

from blazorgooglemaps.

valentasm1 avatar valentasm1 commented on August 12, 2024

Please register new issue then. One bug one issue.

from blazorgooglemaps.

cruiserkernan avatar cruiserkernan commented on August 12, 2024

I can do that, I just thought that since it was a caused by the serialization it was one bigger issue, that control position was just one case where I noticed it. But I understand that it might be a separate thing and could be fixed with less of a code change.
I will create a issue for only the control position and and a pull request only for that.

from blazorgooglemaps.

valentasm1 avatar valentasm1 commented on August 12, 2024

No need PR. Just sample of code how it should is enough since change is very small

from blazorgooglemaps.

valentasm1 avatar valentasm1 commented on August 12, 2024

I merger PR. It dont work. I tried for 30min and give up. Reverted.
If you do functionality. Startup server demo and try markers diff func, drawing polygons, polylines. Maybe smth else.
I am a bit disappointed.

from blazorgooglemaps.

cruiserkernan avatar cruiserkernan commented on August 12, 2024

Sry my bad, I should have tested it more. I will update the code so that it works and thoroughly test it.

from blazorgooglemaps.

Enritski avatar Enritski commented on August 12, 2024

I've been digging into this, and experimenting with a different custom serializer for enums.
I've come to the conclusion that a big part of the problem is due to the use of discriminated unions (OneOf) for various properties. If a type has a property that uses OneOf, the OneOfConverterFactory is used to serialize that property and does so by using the default serializer for whichever of the underlying types is being used. So, for example, in the case of the Symbol class, the Path property is a discriminated union: OneOf<SymbolPath, string>. The SymbolPath type is an enum and will serialize properly using the custom serializer (e.g., JsonStringEnumConverterEx), but not when it is part of a OneOf as is the case here.
I experimented with making the Path property just a simple SymbolPath instead of OneOf<SymbolPath, string> and that worked.
I've been trying to work out how to have the OneOfConverterFactory use the appropriate serializer for each of the possible types in the discriminated union, but haven't got there yet.
I just thought I'd add this comment here in case anyone else has an idea how to achieve this.

from blazorgooglemaps.

valentasm1 avatar valentasm1 commented on August 12, 2024

Sharing knowledge is always great. Thank you.

from blazorgooglemaps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.