Comments (5)
This should probably be scoped to places where char
s are used in arithmetic statements.
from runelite.
Mentioned in discord:
from runelite.
Further notes from @Adam- regarding the work required.
The decision is to either update fernflower completely or simply apply that patch. the version of fernflower I use now is https://github.com/runelite/fernflower and it is versioned and deployed up to repo.runelite.net which the updater pulls in using maven. So you could PR that patch against that repo if you wanted. But to change fernflower you need to manually run the full decompile and mapping procedure locally since the CI does not cover it and I dont know of what impacts it will have
[...]
I wouldnt mind seeing fernflower updated completely if it still functions
[...]
Also I find that the decompiled result of the compiled fernflower decompile is generally drastically different from the decompiled result of the output of the deobfuscator. which I think is due to javac more than anything. so when I update things I will re-map everything and then re-decompile it instead of redecompiling runecsape-client
so you would have to basically get 154, deobfuscate it, map the existing client to it, and then decompile that with the newer ff version and commit that
from runelite.
Fixed in #176
from runelite.
Nice!
from runelite.
Related Issues (20)
- Item hover tooltips not working properly HOT 3
- Team cape x, i, and zero not recognized for emote clue step HOT 1
- Random crashing since upgrading gpu
- WM Resizing Bug Linux (Fix / Solution provided) HOT 2
- Inventory Tags "fill" highlighting is not working correctly for Bird nests
- Key Remap leads to macro ban on macOS Sonoma HOT 3
- Dragon felling axe, Crystal felling axe, and Crystal felling axe (inactive) not recognized for emote clue step HOT 2
- !pb hmt 1 stopped working
- flatlaf migration meta issue HOT 5
- GPU Plugin incorrectly rendering slopes HOT 1
- Medium clue inaccurate information HOT 2
- Game size not booting correctly HOT 2
- Chat-History: can't copy messages to/from friends
- Trailblazer reward item variations not present.
- Un-synced screen markers
- Runelite is preventing the ESC key from working HOT 4
- Compute Shaders broken on macOS HOT 4
- GPU plugin black shadows on effects HOT 4
- gpu regions: unrelated maps show in blast furnace
- Object Markers Permanently Showing Even With the Plugin Disabled? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from runelite.