Coder Social home page Coder Social logo

Comments (5)

kylestev avatar kylestev commented on May 29, 2024

This should probably be scoped to places where chars are used in arithmetic statements.

from runelite.

kylestev avatar kylestev commented on May 29, 2024

Mentioned in discord:

fesh0r/fernflower@e44ba99

from runelite.

kylestev avatar kylestev commented on May 29, 2024

Further notes from @Adam- regarding the work required.

The decision is to either update fernflower completely or simply apply that patch. the version of fernflower I use now is https://github.com/runelite/fernflower and it is versioned and deployed up to repo.runelite.net which the updater pulls in using maven. So you could PR that patch against that repo if you wanted. But to change fernflower you need to manually run the full decompile and mapping procedure locally since the CI does not cover it and I dont know of what impacts it will have
[...]
I wouldnt mind seeing fernflower updated completely if it still functions
[...]
Also I find that the decompiled result of the compiled fernflower decompile is generally drastically different from the decompiled result of the output of the deobfuscator. which I think is due to javac more than anything. so when I update things I will re-map everything and then re-decompile it instead of redecompiling runecsape-client
so you would have to basically get 154, deobfuscate it, map the existing client to it, and then decompile that with the newer ff version and commit that

from runelite.

Adam- avatar Adam- commented on May 29, 2024

Fixed in #176

from runelite.

kylestev avatar kylestev commented on May 29, 2024

Nice!

from runelite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.