[Bug]: FirestoreKVStore's aget_all raises AttributeError when collection is not empty about llama_index

[dosubot]

The issue you're experiencing with FirestoreKVStore's aget_all method is due to not awaiting the doc.get() coroutine before attempting to call to_dict() on its result. This leads to the AttributeError: 'coroutine' object has no attribute 'to_dict' because doc.get() returns a coroutine that needs to be awaited to obtain the document snapshot, which then allows you to call .to_dict() on the snapshot.

Here's how you can fix the method:

async def aget_all(self, collection: str = DEFAULT_COLLECTION) -> Dict[str, dict]:
    collection_id = self.firestore_collection(collection)
    docs = self._adb.collection(collection_id).list_documents()
    output = {}
    async for doc in docs:
        key = doc.id
        doc_ref = await doc.get()  # Await the coroutine to get the document snapshot
        if doc_ref.exists:
            data = doc_ref.to_dict()  # Now you can safely call to_dict on the document snapshot
            if data is None:
                continue
            val = self.replace_field_name_get(data)
            output[key] = val
    return output

By awaiting doc.get(), you ensure that you're working with a document snapshot from which you can safely call .to_dict(), thus resolving the AttributeError.

Details

Sources

• llama-index-core/llama_index/core/ingestion/pipeline.py
• llama-index-integrations/storage/kvstore/llama-index-storage-kvstore-firestore/llama_index/storage/kvstore/firestore/base.py
• llama-index-legacy/llama_index/legacy/storage/kvstore/firestore_kvstore.py

About Dosu
This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

To continue the conversation, mention @dosu.