Comments (23)
I'm thinking maybe we hide the report unless they have entered any recommended levels or non-zero minumums.
from human-essentials.
And I think we should populate both minimum and recommended from the Item levels (I expect you meant that, but being explicit)
from human-essentials.
I realized overnight that, as written, this will not be useful for Sylvia's Sisters. We would need to add a "include in low inventory report" flag on the storage location (and they'll need to add the recommended levels, of course).
from human-essentials.
Right now, it looks like we're configuring "minimum quantity" at the item level, which means that we're assuming all banks should have the same distribution and quantities at every location.
We know this doesn't work for Sylvia's Sisters, but I think it's also an issue for organizations with banks that support different communities. Each community would have a population that needs different items.
I want to propose a change. Could we add a minimum_quantity and recommended_quantity to InventoryItem? We could then use this value to allow banks to set location-specific quantity guidelines.
Sylvia's Sisters could set the minimum_quantity for all their residential locations to 0, but they could also distribute more disposable products to Virginia, and more reusable products to Uganda.
I have an idea for what the roll-out for this could look like, and how to transition minimum_quantity on item to a global value for an item, instead of a per-bank quantity.
from human-essentials.
(I missed the first part of SS's stuff, didn't know they were doing Uganda)
from human-essentials.
What I think I saw with the SS model is they wouldn't ever be concerned about their residential "storage locations" having low inventory. Ever. Because they aren't really storage locations, they are workstations with materials.
from human-essentials.
I understand what you're saying about banks with different communities -- we have other banks that essentially have different branches, and those branches are being represented as storage locations.
from human-essentials.
(Thinking 'aloud' -- apologize in advance for the blathery nature of this) I'm not (yet?) sure that InventoryItem is the right place for this -- I mean, logically it is -- but an InventoryItem only comes into being when Inventory is added to the storage location (until a very short time ago it also disappeared when it was taken down to 0) So there's some flow issues there. I'm a bit concerned about the extra input work, too, for those banks with a lot of storage locations. We'd need to add a whole slice for InventoryItems, right? Though for those banks that have already put recommended levels in, we could do a reasonably smooth default migration.
from human-essentials.
I'm a bit confused by this part of your comment: "and how to transition minimum_quantity on item to a global value for an item, instead of a per-bank quantity." -- minimum_quantity is never going to be at higher than a bank level. Was that a mis-speak, or am I just not getting it?
from human-essentials.
Would be happy to pop onto a Zoom to discuss in the am. Would love to hear your ideas for a relatively painless transition .
from human-essentials.
(Hmmm... what is the reason we don't add InventoryItems until inventory is added to the storage location? Was there a business reason or was it an accident)
from human-essentials.
Transition idea -
- New Columns are added to InventoryItem
- New columns default to 0
- If an item has a minimum quantity, and a storage location has a warehouse type of 'Consumer, self-storage or container space', 'Commercial/office/business space that contains storage space', or 'Warehouse with loading bay', we should populate minimum_quantity on the InventoryItem.
- This can be a rake task that accepts an organization as a parameter, so if we want to update an indivdual bank in the future, we can.
- Start displaying/editing this minimum_quantity in reports, forms, and dashboards
- Start removing the item level minimum_quantity from reports and dashboards
- Reintroduce the item level minimum_quantity as a bank-level global quantity to check against
It'll be slow, but that'll give people time to adapt and change.
from human-essentials.
(Thinking 'aloud' -- apologize in advance for the blathery nature of this) I'm not (yet?) sure that InventoryItem is the right place for this -- I mean, logically it is -- but an InventoryItem only comes into being when Inventory is added to the storage location (until a very short time ago it also disappeared when it was taken down to 0) So there's some flow issues there. I'm a bit concerned about the extra input work, too, for those banks with a lot of storage locations. We'd need to add a whole slice for InventoryItems, right? Though for those banks that have already put recommended levels in, we could do a reasonably smooth default migration.
(Hmmm... what is the reason we don't add InventoryItems until inventory is added to the storage location? Was there a business reason or was it an accident)
I'm okay with it living somewhere other than InventoryItem. I'm looking for a relationship between Item and StorageLocation, and I think this is a good place for it, but if we want to introduce a separate join table, I'm open to that.
I'm a bit confused by this part of your comment: "and how to transition minimum_quantity on item to a global value for an item, instead of a
per-bankper-location quantity." -- minimum_quantity is never going to be at higher than a bank level. Was that a mis-speak, or am I just not getting it?
You're right. I was thinking of locations as bank branches and misspoke.
from human-essentials.
I do think we might want to introduce a separate table -- but only because I'm not positive if there are business reasons for the current InventoryItem behaviour.
from human-essentials.
So, we're thinking in terms of initially doing the report using the levels on Item (pretty sure S'sS doesn't use the recommended levels yet) , then?
from human-essentials.
Re transition: I think we'd want to do some research on the patterns over all the banks -- Sylvia's Sisters might be a special case in how they are using the residential.
from human-essentials.
Hey @ChaelCodes -- just checking if there's anything blocking the initial version of this [I have been assuming we're doing an initial version that uses the item-level minimum and recommended values, then we work on making it better.] ?
from human-essentials.
Hey @ChaelCodes -- just checking if there's anything blocking the initial version of this [I have been assuming we're doing an initial version that uses the item-level minimum and recommended values, then we work on making it better.] ?
Nope! Nothing blocking it. Just haven't had a chance to pick it up since the RFG event. I worked on removing Donation (All Sources), and the Experimental Docker one still needs the Org spec fixed.
from human-essentials.
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.
from human-essentials.
Automatically unassigned after 7 days of inactivity.
from human-essentials.
That initial PR to add the low inventory report is ready for review: #3857
from human-essentials.
Formally assigning @awwaiid because I know Brock's doing a last push to get all the dashboard items in place.
from human-essentials.
This is merged into dashboard
and I manually validated it in addition to the specs. Further changes can be in separate issues and part of the unified dashboard validation.
from human-essentials.
Related Issues (20)
- Flaky distribution test
- Investigate Custom Devise Mailer HOT 1
- Merge line items at request save. Not just for children anymore. () HOT 1
- Rework landing page to use bootstrap instead of tailwind
- [PACKS] # 1 Add custom request units at organizational level HOT 1
- [PACKS] #2 Add reporting units to items HOT 3
- [PACKS] #3 Allowing the selection of custom request units in partner request HOT 1
- [PACKS] # 4 Show the custom units when displaying the request to the partner HOT 3
- [PACKS] #5 Add custom request units (if any) to the confirmation email for partner requests. HOT 1
- [PACKS] # 6 Add custom request units to partner's request list HOT 7
- [PACKS] # 7 Show custom request units in banks' request view
- [PACKS] #8 New / Edit Distribution for the banks shows custom request units, if applicable
- [PACKS] # 9 Distribution printout for banks includes custom request units, if applicable
- [PACKS] #10 Add custom request units to Request export
- [PACKS] 11: Add ability to print all outstanding requests as pick-lists
- [PACKS] #12 Item view should include all fields (including new custom request units) HOT 2
- [PACKS] #13 Calcuate Product Totals
- Bank Request View -- only show fulfillment column if partner has default location
- Account requests and org websites HOT 2
- [BUG]: rspec tests fail in fresh virtual machine dev environments
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from human-essentials.