Coder Social home page Coder Social logo

Comments (11)

schoork avatar schoork commented on May 28, 2024 1

Thanks @phonghpham. It's not quite ready to be worked, since it needs the PR it mentions to be merged first. When it's ready, will circle back to see if you still want to do it.

from casa.

andreLumor avatar andreLumor commented on May 28, 2024 1

Perfect then! I can start working on the issue if you wish.

from casa.

andreLumor avatar andreLumor commented on May 28, 2024 1

Hey @schoork, had some time issues, but now I can finish this task.
One thing I was wondering is the usage of the whenever gem, since it (and other cron gems) doesn't work with heroku apps. (https://github.com/javan/whenever?tab=readme-ov-file#heroku).
Wouldn't it be better to keep using heroku scheduler, as in the linked birthday reminder task?

from casa.

phonghpham avatar phonghpham commented on May 28, 2024

I can work on this.

from casa.

schoork avatar schoork commented on May 28, 2024

@phonghpham The blocking issue and PR has been merged. So this is ready if you want it.

from casa.

andreLumor avatar andreLumor commented on May 28, 2024

Hello! One question about this issue.
From what I could see in the controller, what defines a draft is status being different from "active". Wouldn't this change also delete old case contacts? since they have "started" status by default and empty draft_case_ids

from casa.

schoork avatar schoork commented on May 28, 2024

There was an after party task that ran on deployment that set their status as active.

from casa.

schoork avatar schoork commented on May 28, 2024

@andreLumor lib/tasks/deployment/20231125151610_set_case_contacts_as_active.rake

from casa.

github-actions avatar github-actions commented on May 28, 2024

This issue has been inactive for 250 hours (10.42 days) and will be unassigned after 110 more hours (4.58 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

from casa.

github-actions avatar github-actions commented on May 28, 2024

This issue has been inactive for 370 hours (15.42 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.

from casa.

schoork avatar schoork commented on May 28, 2024

Hey @schoork, had some time issues, but now I can finish this task. One thing I was wondering is the usage of the whenever gem, since it (and other cron gems) doesn't work with heroku apps. (https://github.com/javan/whenever?tab=readme-ov-file#heroku). Wouldn't it be better to keep using heroku scheduler, as in the linked birthday reminder task?

Yeah, didn't know that about Heroku and cron, but Heroku scheduler sounds good.

from casa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.