Comments (29)
I believe PlainAdmin uses the native browser dropdown styling. if that's correct, let's go with that.
As far as country goes, I think our target users are located in the US. Is this correct @bcastillo32 ?
from casa.
Hey @bcastillo32 - I'd love to work on this. Can you please assign it to me?
from casa.
I believe PlainAdmin uses the native browser dropdown styling. if that's correct, let's go with that. As far as country goes, I think our target users are located in the US. Is this correct @bcastillo32 ?
Yes! users are in the US. @chahmedejaz
from casa.
hi @chahmedejaz I just saw your comment and hope you are feeling better! Let us know if there is anything we can do to help or if you are experiencing any blockers. Feel better soon! ❤️
from casa.
Hi @chahmedejaz how are you feeling? are you ok? Please let me know. I hope all is well.
I'm feeling much better now, thanks for asking 😇 I've some concerns regarding regarding the new address field. let me do some spike and get back to you on this. Thanks.
Great to hear you are feeling better. and ok sounds good. let us know how we can be of help. 👍🏼
from casa.
@bcastillo32 I'll take this.
from casa.
hi @bcastillo32
It's coming along. A rough todo list of remaining tasks:
- add dollar sign to the "expense amount" field
- split address field up into different sections for street, city, state, etc.
- little details with button styling
Most other changes have been made. The address thing may take me some time to work through because it'll surely involve some digging into how the form is consumed on the backend.
No blockers for now though. Will let you know if/when we run into one 👍
from casa.
Hey @bcastillo32 - I've a question here.
- Now for the address field, we have a states dropdown. Do we have to implement the same states as shown in the Figma?
- Because I believe states depend upon the entered country.
- How do we want to handle this? Thanks.
from casa.
This issue has been inactive for 240 hours (10.00 days) and will be unassigned after 120 more hours (5.00 days). If you have questions, please
If you are still working on this, comment here to tell the bot to give you more time
from casa.
I'm working on it however, I'm sick these days. Will continue the work soon. Thanks.
from casa.
This issue has been inactive for 241 hours (10.04 days) and will be unassigned after 119 more hours (4.96 days). If you have questions, please
If you are still working on this, comment here to tell the bot to give you more time
from casa.
This issue has been inactive for 361 hours (15.04 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.
from casa.
I'm working on it however, I'm sick these days. Will continue the work soon. Thanks.
Hi @chahmedejaz how are you feeling? are you ok? Please let me know. I hope all is well.
from casa.
Hi @chahmedejaz how are you feeling? are you ok? Please let me know. I hope all is well.
I'm feeling much better now, thanks for asking 😇
I've some concerns regarding regarding the new address field. let me do some spike and get back to you on this. Thanks.
from casa.
Hey - I'm getting a little busier with my office these days. I might not be able to complete it soon. Sorry for holding this for a long time 😢
Anyone can pick this up.
from casa.
@bcastillo32 I'll take this.
Hi @ycorredius thank you! Assigning you now!
from casa.
This issue has been inactive for 263 hours (10.96 days) and will be unassigned after 97 more hours (4.04 days). If you have questions, please
If you are still working on this, comment here to tell the bot to give you more time
from casa.
This issue has been inactive for 383 hours (15.96 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.
from casa.
This issue has been inactive for 599 hours (24.96 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.
from casa.
If this is open, I'd be glad to work on it @bcastillo32
from casa.
@bcastillo32 You can assign it to @JoshDevHub. I didn't have time to complete this.
from casa.
This issue has been inactive for 246 hours (10.25 days) and will be unassigned after 114 more hours (4.75 days). If you have questions, please
If you are still working on this, comment here to tell the bot to give you more time
from casa.
hi @JoshDevHub how are you coming along? Are you experiencing any blockers? any questions? :)
from casa.
hi @bcastillo32
It's coming along. A rough todo list of remaining tasks:
- add dollar sign to the "expense amount" field
- split address field up into different sections for street, city, state, etc.
- little details with button styling
Most other changes have been made. The address thing may take me some time to work through because it'll surely involve some digging into how the form is consumed on the backend.
No blockers for now though. Will let you know if/when we run into one 👍
Thanks for the update @JoshDevHub - if you need help please let me know and feel free to reach out in our slack in our #proj-case-contact-refactor channel.
from casa.
Hi @bcastillo32
We're still working on this, and we had some questions about the new way the form is handling the address field.
Currently, the address is all one text string. This is the case for both the form and how the data is stored internally in the database:
The updated design segments the address into different parts in the form like this:
But this creates a discrepancy between how the data is stored (all in one string), and how it is displayed in this form. This can be especially a problem for the existing data on the site, which may or may not neatly fit into the new way this is organized. It's difficult to guarantee the existing data will play nicely with this update.
I think to do this well, we'd have to add new fields to the addresses
table. Currently it's like this:
create_table "addresses", force: :cascade do |t|
t.string "content" # string that holds full address
t.bigint "user_id", null: false
end
when it would map better to the new form as something like:
create_table "addresses", force: :cascade do |t|
t.string "street_address"
t.string "city"
t.string "state"
t.string "zip_code"
t.bigint "user_id", null: false
end
But this would require a migration from the way the data is currently organized into a new way of doing it, which would definitely be out of scope for this ticket.
We could also try writing something that would separate the one string up into constituent pieces, but I'd estimate this would likely run into issues with the way people have formatted their addresses, used punctuation, etc. under the current system.
Do y'all have any thoughts for how to proceed with this?
from casa.
Hi @bcastillo32
We're still working on this, and we had some questions about the new way the form is handling the address field.
Currently, the address is all one text string. This is the case for both the form and how the data is stored internally in the database:
The updated design segments the address into different parts in the form like this:
But this creates a discrepancy between how the data is stored (all in one string), and how it is displayed in this form. This can be especially a problem for the existing data on the site, which may or may not neatly fit into the new way this is organized. It's difficult to guarantee the existing data will play nicely with this update.
I think to do this well, we'd have to add new fields to the
addresses
table. Currently it's like this:create_table "addresses", force: :cascade do |t| t.string "content" # string that holds full address t.bigint "user_id", null: false endwhen it would map better to the new form as something like:
create_table "addresses", force: :cascade do |t| t.string "street_address" t.string "city" t.string "state" t.string "zip_code" t.bigint "user_id", null: false endBut this would require a migration from the way the data is currently organized into a new way of doing it, which would definitely be out of scope for this ticket.
We could also try writing something that would separate the one string up into constituent pieces, but I'd estimate this would likely run into issues with the way people have formatted their addresses, used punctuation, etc. under the current system.
Do y'all have any thoughts for how to proceed with this?
Hi @JoshDevHub thank you bringing this to my attention and for detailed explanation. Before I make a final decision, I’m going to run this by design. Seeing that it would require a major change to how data is stored, I’m leaning toward sticking with one field but let me make sure with design first. I’ll be in touch!
from casa.
@JoshDevHub go ahead and leave the address as one field. Thanks for checking and for pointing this out. Let us know if you need anything else :)
from casa.
This issue has been inactive for 243 hours (10.13 days) and will be unassigned after 117 more hours (4.88 days). If you have questions, please
If you are still working on this, comment here to tell the bot to give you more time
from casa.
This issue has been inactive for 363 hours (15.13 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.
from casa.
Related Issues (20)
- Update Phone Number Input HOT 13
- Refactor: update soft-deprecated form helpers
- Migrate Case Contact Notes to Corresponding Section When Generating Court Report HOT 3
- Format date to US format MM/DD/YYYY HOT 10
- New Line Chart: WAU (Weekly Active Users) by Role HOT 7
- Bug: Health Page - contacts without notes calculated incorrectly HOT 1
- Bug: Weekly supervisor email bottom section includes unknown names - probably volunteers from other orgs HOT 5
- left navbar edit: un-nest "Generate Court Reports" for Volunteers HOT 8
- Banner Expiration HOT 2
- Bug: Case Contact Contact Type Selection HOT 1
- Convert all validity specs in spec/models/case_contact_spec.rb to assert which errors are present HOT 1
- safely upgrade gem "noticed" to latest
- Add polymorphic columns to Followup and backfill data HOT 2
- Start adding polymorphic reads to replace old followups via case_contact HOT 2
- Refactor: Display Volunteer name next to Case Number HOT 1
- add test for org scoping in supervisor weekly email
- Add test for successfully submitting case contact for volunteer with only one case HOT 1
- Fix heroku buildpack order HOT 3
- Bug: do not allow invalid dates
- Implement User login tracking details HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from casa.