Failures with tzdata-2022b about spec

[junaruga]

I sent the PR: #939.

[eregon]

Interesting, so Europe/Amsterdam in 1940 is not CEST but "WEST"?
Does the test pass by changing to 1970? PR welcome BTW.

because it seems that 1940 was originally chosen on purpose.

Because of fb2bf67 ?

Changing the expectation to WEST wouldn't work against older tzdata, so using a different year seems more reliable.

[junaruga]

I investigated this issue.

Because of fb2bf67 ?

It seems that the commit above added the test cases. But according to the comment for tzdata RPM package issue ticket on Fedora, and checking the tzdata project, here is the caused commit. This is intentional. The change is new in tzdata version "2022b".

eggert/tz@35fa37f

On ruby/ruby, I found the commit to comment out the tests. My guess is that it is a temporary workaround to pass the tests. And the "2022c" is not accurate. It should be "2022b".

The tzdata 2022c removed Amsterdam Mean Time
ruby/ruby@b7577b4

Changing the expectation to WEST wouldn't work against older tzdata, so using a different year seems more reliable.

I would suggest this patch for the ruby/ruby and ruby/spec.

diff --git a/spec/ruby/core/time/shared/local.rb b/spec/ruby/core/time/shared/local.rb
index 997b7186f1..bd33fa01ac 100644
--- a/spec/ruby/core/time/shared/local.rb
+++ b/spec/ruby/core/time/shared/local.rb
@@ -6,18 +6,18 @@
     end
   end
 
-=begin
   platform_is_not :windows do
     describe "timezone changes" do
       it "correctly adjusts the timezone change to 'CEST' on 'Europe/Amsterdam'" do
         with_timezone("Europe/Amsterdam") do
-          Time.send(@method, 1940, 5, 16).to_a.should ==
-            [0, 40, 1, 16, 5, 1940, 4, 137, true, "CEST"]
+          [
+            [0, 40, 1, 16, 5, 1940, 4, 137, true, "CEST"],
+            [0, 0, 0, 16, 5, 1940, 4, 137, true, "WEST"]
+          ].should include(Time.send(@method, 1940, 5, 16).to_a)
         end
       end
     end
   end
-=end
 end
 
 describe :time_local_10_arg, shared: true do

[eregon]

Could you make a PR with that?

Also would it work to change 1940 by 1970? I think that would be simpler.

[junaruga]

Sure. I will send the PR with the 1970.