ActiveJob #deliver_later! ignores queue settings in config/shoryuken.yml and always try to use "mailers" queue about shoryuken

[rusllonrails]

Ahh looks like Rails Mailer uses mailers queues when delivering email

[rusllonrails]

yep.

require 'active_job'

module ActionMailer
  # The <tt>ActionMailer::DeliveryJob</tt> class is used when you
  # want to send emails outside of the request-response cycle.
  class DeliveryJob < ActiveJob::Base # :nodoc:
    queue_as :mailers

    def perform(mailer, mail_method, delivery_method, *args) #:nodoc:
      mailer.constantize.public_send(mail_method, *args).send(delivery_method)
    end
  end
end

[rusllonrails]

Looks like we can only set following ops for DeliveryJob class:

config.active_job.queue_name_prefix = Rails.env
config.active_job.queue_name_delimiter = '.'

And can override name only in separated classes like:

class ExampleJob < ActiveJob::Base
  # Set the Queue as Default
  queue_as :default

  def perform(*args)
    # Perform Job
  end
end

Yep. That's fine =)
Sorry for disturbing guys and thanks for nice gem 👍
I think it's good to close

[rjungemann]

@RuslanHamidullin I'm glad that you found a solution to your issue, but I can't figure out how to get it to work given the information you provided. How do I override my mailer to use a different queue other than "mailers"?

[rusllonrails]

hey @rjungemann
So there are no easy way to specify custom 'queue' name per mailer.
On my app I solved problem via using convention:

Each environment have 1 queue for app jobs, and 1 queue for mailers

I added config/initializers/active_job_shoryuken.rb

Rails.application.configure do
  if Rails.env.staging? || Rails.env.production?
    # For 'Staging' and "Production" use 'shoryuken' adapter 
    config.active_job.queue_adapter = :shoryuken
    config.active_job.queue_name_prefix = Rails.env
    config.active_job.queue_name_delimiter = "_"
  else
    # Use default active job 'inline' adapter for 'Test' and 'Development' environments
    config.active_job.queue_adapter = :inline
  end
end

So that for staging would be 2 queues:

staging_default # For app jobs
staging_mailers # For mailers

And similar for production:

production_default
production_mailers

[phstc]

Hi @RuslanHamidullin

I'm glad you found that out. I would recommend you to have more granular queues per jobs, so you would be able to configure their priorities separately with Shoryuken.

Another option for the queue_name_prefix, would be to use something like ENV['USER'] in development, so the developers can have individual queues to "facilitate" their tests.

Here we use ENV variables (dotenv in development) to configure the queue prefixes.

[rusllonrails]

@phstc yeah, that make sence.
Thanks 🍻

[kesha-antonov]

Thanks for this. Useful!

[gshutler]

I was looking into this and found this thread. For future reference this has been made configurable via config.action_mailer.deliver_later_queue_name rails/rails#18587 but hasn't made it into a release at the time of writing.

[rusllonrails]

sounds good 👍

[phstc]

nice 👍