Comments (3)
This isn't currently being tested in extract.coffee/comments.js. But when I added a test, it passed. There must be something funky going on. I'll investigate more.
from angular-gettext-tools.
I think it's an issue with how the AST is walked when comments are inside arrays.
This works:
var foo = [
/// comment will be extracted
gettextCatalog.getString(gettext('foo'))
];
This doesn't:
var foo = [
/// comment will NOT be extracted
gettext('foo')
];
Neither does this:
var foo = [
/// comment will NOT be extracted
gettextCatalog.getString('foo')
];
I wonder how many other forms don't work.
from angular-gettext-tools.
Hmmm, that's unfortunate. Rather strange that it generates different AST.
I guess we'll have to add more and more test cases until we cover them all.
The whack-a-mole strategy :-)
On Fri, Nov 14, 2014 at 6:36 PM, Gabe Gorelick [email protected]
wrote:
I think it's an issue with how the AST is walked when comments are inside
arrays.This works:
var foo = [
/// comment will be extracted
gettextCatalog.getString(gettext('foo'));
];This doesn't:
var foo = [
/// comment will NOT be extracted
gettext('foo');
];Neither does this:
var foo = [
/// comment will NOT be extracted
gettextCatalog.getString('foo');
];I wonder how many other forms don't work.
—
Reply to this email directly or view it on GitHub
#46 (comment)
.
from angular-gettext-tools.
Related Issues (20)
- Handlebars and CDATA within html script element does not parse since 2.2.0 HOT 1
- Got error while parsing JS file using https://www.npmjs.com/package/angular-gettext-cli HOT 1
- Angular bind-once issue
- Babel support? HOT 1
- Feature: compile one message per line
- Webpack issue HOT 1
- The use of the $ (dollar) symbol throws an error HOT 2
- Add Pug support HOT 2
- Upgrade peer dependency typescript-eslint-parser to recent version - outdated depending typescript version prevents shrinkwrapping HOT 4
- .pot overriding controller text HOT 2
- Broken for ES5 since 2.3.6 HOT 4
- Extraction from $templateCache
- Annotated strings HOT 1
- JSX/TSX syntax is forced in TS code
- No location of parse error reported HOT 1
- Cannot extract "constructor" HOT 3
- Looking for a maintainer
- Typescript 3 support HOT 2
- Do not introduce breaking changes in minor versions HOT 1
- Somehow template literals become empty after extraction
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-gettext-tools.