Comments (2)
I find this approach very interesting. The current regex approach is very limited, and most of the advantage of angular-gettext is the ability to automatically extract translation strings, so improving that aspect seems very important to me.
It's a pretty funky hack to get access to the angular parser. Glancing on parse.js, it looks like it's only dependent on $filter, and even that looks like its using $filter mostly to determine if an expression is constant or not (which we don't really need). So I guess it should be readily mockable.
from angular-gettext-tools.
In kvantetore/angular-gettext-tools@7e5e520, I've changed the parser from regex based to the angular expression parser based on the work by @yankee42. I can format a proper pull request if there is interest in folding into the mainline.
Instead of looking for interpolation expressions globally in the html template, the new approach is to parse the attributes and text-tags of each node separately. This has caused a minor regression in the test suite, namely in "extract/Extracts strings from non-delimited attribute", the line number of the second string is reported to be on line 3 instead of 5
from angular-gettext-tools.
Related Issues (20)
- Handlebars and CDATA within html script element does not parse since 2.2.0 HOT 1
- Got error while parsing JS file using https://www.npmjs.com/package/angular-gettext-cli HOT 1
- Angular bind-once issue
- Babel support? HOT 1
- Feature: compile one message per line
- Webpack issue HOT 1
- The use of the $ (dollar) symbol throws an error HOT 2
- Add Pug support HOT 2
- Upgrade peer dependency typescript-eslint-parser to recent version - outdated depending typescript version prevents shrinkwrapping HOT 4
- .pot overriding controller text HOT 2
- Broken for ES5 since 2.3.6 HOT 4
- Extraction from $templateCache
- Annotated strings HOT 1
- JSX/TSX syntax is forced in TS code
- No location of parse error reported HOT 1
- Cannot extract "constructor" HOT 3
- Looking for a maintainer
- Typescript 3 support HOT 2
- Do not introduce breaking changes in minor versions HOT 1
- Somehow template literals become empty after extraction
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-gettext-tools.