shallow merge problem in autoRehydrate about redux-persist

[rt2zz]

This definitely looks like a bug introduced by some for in changes we made. I would prefer to stay away from munging the proto. Perhaps if we detect the object is not plain we can just wholesale set the substate instead of doing for in?

[baabgai]

Maybe instead of hacking with proto we could just use Object.create instead of the object literal initialization of subState.
Assuming reducedState, subState and data are both objects of the same type the code could look like

...
var subState = Object.create(Object.getPrototypeOf(data))
for (var subkey in reducedState[key]) {
    if (reducedState[key].hasOwnProperty(subkey)) subState[subkey] = reducedState[key][subkey]
}
for (var datakey in data) {
    if (data.hasOwnProperty(datakey)) subState[datakey] = data[datakey]
}
autoReducedState[key] = subState
...

This should equally work for immutable and plain objects and might be a cleaner and more official way to do it I guess.

[rt2zz]

how about: https://github.com/rt2zz/redux-persist/blob/master/src/autoRehydrate.js#L38

With isPlainObject check, immutable objects would be wholesale copied instead of shallow merged

[rt2zz]

ok I pushed the isPlainObject change to master let me know if that solves the issue

[baabgai]

ok.
After a few more tests I figured that's actually a much better idea since no data is saved on the first level anyhow for immutables, so a shallow merge done like I suggested would actually always overwrite one immutable object with the other one and not merge anything.

[rt2zz]

After messing with this more and working on 2.0, I think this is the correct approach. Thanks for reporting!

[arilitan]

I'm running into an issue where one of my reducers is storing state as immutable objects. When I rehydrate the store however, it is saving as a plain object not an immutable one. Any ideas how to fix?

[rt2zz]

@arilitan this should work for you: https://github.com/rt2zz/redux-persist-transform-immutable