Case where default value of an argument is some object/methods from a module about reticulate

[jjallaire]

Fixed via: 83353fe

[terrytangyuan]

This is kinda trick for edge cases, e.g. https://github.com/tensorflow/tensorflow/blob/master/tensorflow/contrib/layers/python/layers/initializers.py#L31. Also another question is how to generalize this for other python packages. But I understand manual process is necessary anyways.

[terrytangyuan]

Maybe just replace any . by $. Also a question what if we have import someModule as ...

[jjallaire]

Here's a commit (still on a branch) that does more aggressive conversion:

reticulate::py_function_wrapper("tf$contrib$layers$sparse_column_with_keys")

Then I thought about, "what if the value is a string and it includes a period?" :-(

Also, in the case of dtypes$ there is no guaranteed that there is a dtypes object available to reference.

I think it does indeed come down to the fact that hand editing after the fact will always be necessary to do some cleanup, so we should focus conversion on automating what's time consuming and not sweat if some things aren't handled perfectly.

[terrytangyuan]

Yeah totally agree. At least the wrapper generator can save 90% time now.