Coder Social home page Coder Social logo

Comments (3)

rich-iannone avatar rich-iannone commented on June 10, 2024 1

It's all good! There's so many moving parts here and you've navigated all of this really well. I do think the in-reportπŸ’₯ with those very cases would be ideal. We could even alter the error message that appears when hovering over the πŸ’₯ in this case. Thinking about this more deeply, I remember that serially() also offers pretty good safety measures for this sort of thing (e.g., check that column exists, then validate that column) but it's not great for checking multiple columns after the preliminary tests.

Thanks for getting further in the weeds on this part of the package!

from pointblank.

yjunechoe avatar yjunechoe commented on June 10, 2024

Sorry @rich-iannone for accidentally introducing some weird behavior during tidyselect integration πŸ˜…. But these are good to know! I agree that this is a good opportunity to modernize this while we're at it.

Just one follow-up Q: could we move forward treating columns = NULL the same as create_agent(exibble) |> col_vals_lt(columns = starts_with("z") and πŸ’₯ at report? Both would be a case of "you probably didn't mean to select 0 columns so we'll gently nudge you to specify columns or pair this selection attempt with active"

I'll think through some of these edgecases more and try to tackle this in a separate PR (after merging the documentation PR and getting tidyselect for has_columns()). I'll use this issue to dump some thoughts that come up in the meantime

from pointblank.

yjunechoe avatar yjunechoe commented on June 10, 2024

Closed by #499

from pointblank.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.