Coder Social home page Coder Social logo

Comments (5)

OlegDokuka avatar OlegDokuka commented on June 12, 2024

@Svenskunganka! Sounds relevant!

Feel free to contribute if you see the direct solution, otherwise, I will investigate it!

Best,
Oleh

from rsocket-java.

Svenskunganka avatar Svenskunganka commented on June 12, 2024

Hi Oleh!

If my possible solution is acceptable I can definitely contribute it! But if you perhaps know of another way this could be solved without needing to perform an instanceof check for every discarded object that might be a better route to explore.
From my limited experience the only thing I can think of is using e.g Mono.using()/Flux.using() when creating a Payload.

input.flatMap(bytes -> Mono.using(
    () -> ByteBufPayload.create(bytes),
    data -> ...,
    Payload::release
));

Kind regards,
Tom

from rsocket-java.

luczus avatar luczus commented on June 12, 2024

Hi Oleh, @Svenskunganka!

I've created PR #1079 with a fix.
Please let me know what you think about these changes.

Best
Lukasz

from rsocket-java.

tukez avatar tukez commented on June 12, 2024

I noticed the same problem and in my case at least the offending instance is of type org.springframework.core.io.buffer.NettyDataBuffer which holds a ByteBuf. Should the inner ByteBuf be released? That is not possible (other than reflection) in rsocket-java though?

from rsocket-java.

kmccarp avatar kmccarp commented on June 12, 2024

@OlegDokuka are there any plans to integrate the changes made by @luczus? This is heavily polluting our logs.

from rsocket-java.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.