Coder Social home page Coder Social logo

Comments (5)

shrinathaithal avatar shrinathaithal commented on July 19, 2024 2

@turtlemonvh is it okay if 200 is returned for "every" case?

from cors.

rs avatar rs commented on July 19, 2024

I'm not sure to fully understand what's going on by just reading your issue. I will try to find some time to study the behavior with Gin. I leave this issue open in the meantime.

from cors.

DSpeichert avatar DSpeichert commented on July 19, 2024

Have the same exact problem using Macaron - also using HandlerFunc

from cors.

EwanValentine avatar EwanValentine commented on July 19, 2024

I'm using this set-up...

        c := cors.New(cors.Options{
		AllowedOrigins:     []string{"*"},
		AllowCredentials:   true,
		OptionsPassthrough: true,
	})

	handler := c.Handler(api.router)

	// Run
	log.Fatal(http.ListenAndServe(port, handler))

With Gorilla mux router, getting 404 OPTIONS

from cors.

turtlemonvh avatar turtlemonvh commented on July 19, 2024

@shrinathaithal Sorry I didn't see this before. I think that returning a 200 is always ok for OPTIONS requests if OptionsPassthrough is set to false, since this sort of implies that this library is handling OPTIONS requests for you.

It looks like that was fixed per #26, which solves my short term problems, at least.

from cors.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.