Coder Social home page Coder Social logo

Comments (2)

apt1002 avatar apt1002 commented on May 4, 2024

The GForth implementation implements it like this:

Cell olddiff = n1-nlimit;
n2=n1+n;	
if (((olddiff^(olddiff+n))    /* the limit is not crossed */
     &(olddiff^n))	       /* OR it is a wrap-around effect */
    >=0) { /* & is used to avoid having two branches for gforth-native */
{ ... }

I can understand this by separately deoptimising the n>=0 and n<0 cases:

Cell olddiff = n1-nlimit;
n2=n1+n;	
Cell newdiff = n2-nlimit;
if ((n >= 0) ? (
    olddiff < 0 && newdiff >=0
) : (
    olddiff >=0 && newdiff < 0
)) { ... }

In other words, we exit the loop if olddiff and newdiff have opposite sign and olddiff and n have opposite sign.

from beetle.

rrthomas avatar rrthomas commented on May 4, 2024

Submit a patch to gforth based on the above, which replaces the comment "check this thoroughly", and removes the comment about defunct gforth-native.

from beetle.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.