Comments (4)
rrrene
commented on August 29, 2024
Ah, did not think of this. Thanks for reporting! 👍
from credo.
rrrene
commented on August 29, 2024
@eksperimental I released a fix in v0.3.12 
I'm not really sure if it was a good idea that [], {} and () pairs are all treated by the same check inside Credo. Your case above makes it clear that there are subtle differences in their semantics, so I think I should separate each of these into their own checks for v0.4.0.
Thoughts?
from credo.
eksperimental
commented on August 29, 2024
thank you!
from credo.
eksperimental
commented on August 29, 2024
I think I missed your previous comment,
I think [ ] and { } are fine to have the rule, parentesis are a special case as I cannot think a case where you would use a comma at the end.
from credo.
Related Issues (20)
- MissedMetadataKeyInLoggerConfig is incorrect HOT 5
- Fails to running mix credo diff HOT 7
- `There should be no more than 1 consecutive blank lines.` should not trigger for string data HOT 4
- Invalid warnings on typespecs with bitstrings HOT 3
- `No files found` (OTP 26? MacOS?) HOT 5
- Consider including CHANGELOG.md in the package? HOT 4
- Different output when running credo with the `--read-from-stdin` option HOT 4
- Question: Is it possible to define a .credo.exs in a dependency with custom checks and apply it when running mix credo in a project HOT 3
- Predicate function names check does not work for non-zero arity functions HOT 2
- Add list of standard checks to docs HOT 2
- Credo.Check.Warning.Dbg does not detect `dbg` HOT 8
- #FIXME fails silently HOT 6
- Credo wrongly reports about macro name HOT 2
- Credo.Check.Warning.MissedMetadataKeyInLoggerConfig reporting false errors since 1.7.2 upgrade HOT 8
- Elixir version check fails with Credo.Check.Warning.LazyLogging HOT 1
- Credo warning /test/add_credo_plugin_to_project.exs:121:6 HOT 2
- Code readability: Predicate function names should not start with 'is', and should end in a question mark. HOT 1
- Command line switch `--read-from-stdin` doesn't respect config files HOT 4
- Predicate callbacks from behavior are not ignored HOT 2
- Issue with Unused variables confused about the strategy HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from credo.