Coder Social home page Coder Social logo

Cast bootstrap-expect (and node-id) to string when it's a number to prevent breaking containers created via the docker API about rqlite HOT 5 CLOSED

joostdecock avatar joostdecock commented on September 27, 2024
Cast bootstrap-expect (and node-id) to string when it's a number to prevent breaking containers created via the docker API

from rqlite.

Comments (5)

joostdecock avatar joostdecock commented on September 27, 2024

Almost forgot: If you do want to make either change (docs or casting to string) I am happy to submit a pull request for either.

from rqlite.

joostdecock avatar joostdecock commented on September 27, 2024

The exact same issue applies to -bootstrap-expect which is arguably more problematic as that one is a number. From the docs:

-bootstrap-expect should be set to the number of nodes that must be available before the bootstrapping process will commence, in this case 3.

I will update the issue accordingly.

from rqlite.

otoolep avatar otoolep commented on September 27, 2024

Thanks for the report. However I don't understand how changing rqlite source code can fix this. Is this error an error from the Docker API?

from rqlite.

otoolep avatar otoolep commented on September 27, 2024

Perhaps you could detect that node-id is a number and cast it to a string.

This is the part I don't understand. My mental model of what you are seeing is that all these issues occur before anything is passed to rqlited. Therefore I don't understand how I can address.

from rqlite.

joostdecock avatar joostdecock commented on September 27, 2024

Please forgive me, I saw the Golang error and presumed it was coming from rqlite, when in fact, it comes from the Docker daemon.

Love rqlite by the way, can't thank you enough for your work on this 🙏

closing

from rqlite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.