Coder Social home page Coder Social logo

Comments (4)

johndoh avatar johndoh commented on July 24, 2024 1

Its possible to to do this with the following line:

array_push($this->prop['plugins'], 'emoticons', 'twofactor_gauthenticator');

from roundcubemail.

alecpl avatar alecpl commented on July 24, 2024

Indeed this is not supported and using $this would be a hack. Maybe we could implement what you need. I suppose the change in rcube_config::load_from_file() would be needed.

Something like this might work, but I'm not sure I like it:

--- a/program/lib/Roundcube/rcube_config.php
+++ b/program/lib/Roundcube/rcube_config.php
@@ -302,6 +302,8 @@ class rcube_config
             if ($fpath && is_file($fpath) && is_readable($fpath)) {
                 // use output buffering, we don't need any output here
                 ob_start();
+                global $config;
+                $config = $this->prop;
                 require $fpath;
                 ob_end_clean();

from roundcubemail.

CodeShakingSheep avatar CodeShakingSheep commented on July 24, 2024

Its possible to to do this with the following line:

array_push($this->prop['plugins'], 'emoticons', 'twofactor_gauthenticator');

Thanks, this workaround works on my server.

from roundcubemail.

CodeShakingSheep avatar CodeShakingSheep commented on July 24, 2024

Indeed this is not supported and using $this would be a hack. Maybe we could implement what you need. I suppose the change in rcube_config::load_from_file() would be needed.

Something like this might work, but I'm not sure I like it:

--- a/program/lib/Roundcube/rcube_config.php
+++ b/program/lib/Roundcube/rcube_config.php
@@ -302,6 +302,8 @@ class rcube_config
             if ($fpath && is_file($fpath) && is_readable($fpath)) {
                 // use output buffering, we don't need any output here
                 ob_start();
+                global $config;
+                $config = $this->prop;
                 require $fpath;
                 ob_end_clean();

Thanks for considering this issue @alecpl . Despite of the workaround, I would prefer a cleaner solution, like the one that you suggested. So, I'd appreciate if this gets implemented. Until then, I'll use the workaround.

from roundcubemail.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.