Comments (5)
@FabianTerhorst
Will do, and thanks for the link.
from bottombar.
@FabianTerhorst @roughike Hi guys, I'm the author of the mentioned behavior and article. I forked the repo and tried to add it to the lib. It wont work because of two things:
First: BottomBar is attached to content view which is FrameLayout
not CoordinatorLayout
Second: The content is always above it, not behind it. Which means that it will leave empty (window background color will be visible) space when the BottomBar is hidden.
I assume this is for favoring the SnackBars, but they should be handled by behavior (lol, mine doesnt care about snackbars)
Also the content view should be given a proper padding in order the bottom bar and content view do not overlap. This would be applicable if the BottomBar is not attached directly to the android.R.id.content.
IMHO, the BottomBar should not be added directly to the content view, it should work like any other view.Basically, BottomBar should work as ViewGroup out of the box. This is totally subjective opinion and should not be taken as true.
Possible solution is checking if the child at 0 is CoordinatorLayout and avoid removing it in attach method. I mean overall rearrangement of the views. This needs tremendous efforts to be invested, because we have a unknown number of child inside CoordinatorLayout add padding so the content does not overlap.
What I have tried:
Binding the behavior whenever LayoutParams are added to the BottomBar.
I'm subscribing this issue for any comments.
from bottombar.
@NikolaDespotoski
Huge thanks for your awesome gist! I modified your code a bit and although it took a while, I finally got it to work.
This is now supported starting from version 1.1.4. See here for instructions.
Demo:
from bottombar.
IMHO, the BottomBar should not be added directly to the content view, it should work like any other view.Basically, BottomBar should work as ViewGroup out of the box. This is totally subjective opinion and should not be taken as true.
I might make some kind of BottomBarLayout ViewGroup that auto-detects the user's content layout available in the future.
Currently there shouldn't be nothing that can't be done with the BottomBar just because it can't be used by XML. I'm busting my ass implementing everything in the Material Design spec (and squashing bugs all the time), so the XML usage is low priority ATM.
from bottombar.
@NikolaDespotoski, @roughike Thnaks for exmplanations.
As you can see the navigation bottoms don't go transparent on scroll to down.
Do you know any way to achieve this?
I've been able to achive this result, but bottom bar is hiding behind navigation bottom instead of just hiding.
from bottombar.
Related Issues (20)
- Not support set badge count in text format HOT 3
- Bump to version 26 HOT 1
- bottom bar not working on first time
- Change The BottomBar selected with Swipe Gesture
- How to change the icon in the code?
- Does it support changing the title color only? HOT 1
- How can I change the color of bottom bar item title , without affecting the bottom bar icon ?
- How do I remove the shadow of the click HOT 1
- Call Fragment onTabSelect
- "iconsOnly" doesn't center the icon in the view container
- BottomBar crashes when "minSdkVersion" is set to 21 HOT 1
- BottomBarBadge is not accessible.
- Crash: NullPointerException
- Vector image
- disable first tab autoselection HOT 2
- Programmatically activate tab without firing events
- Shy behaviour is not working
- open third tab onstart HOT 3
- Will this library support in SDK level 30 ?
- 可否实现选中一个图片,未选中一个图片 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bottombar.